Skip to content

[RN 0.52] RCTImageLoader requires main queue setup since it overrides init but doesn't implement requiresMainQueueSetup #17504

Closed
@fungilation

Description

@fungilation

Is this a bug report?

Yes

Have you read the Contributing Guidelines?

Yes

Environment

Environment:
  OS: macOS Sierra 10.12.6
  Node: 9.3.0
  Yarn: 1.3.2
  npm: 5.6.0
  Watchman: 4.9.0
  Xcode: Xcode 9.2 Build version 9C40b
  Android Studio: Not Found

Packages: (wanted => installed)
  react: 16.2.0 => 16.2.0
  react-native: 0.52.0 => 0.52.0

Steps to Reproduce

$ react-native run-ios

Expected Behavior

iOS simulator run without errors.

Actual Behavior

screenshot 2018-01-09 14 53 14

screenshot 2018-01-09 15 02 18

^

Module RCTImageLoader requires main queue setup since it overrides `init` but doesn't implement `requiresMainQueueSetup`. In a future release React Native will default to initializing all native modules on a background thread unless explicitly opted-out of.

Reproducible Demo

Any app using the Image component, although in my app I wrap that in a higher level component I use: react-native-fit-image.

I've never seen RCTImageLoader complain about requiresMainQueueSetup before. Only started now after I upgraded RN from 0.51 to 0.52.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Ran CommandsOne of our bots successfully processed a command.Resolution: FixedA PR that fixes this issue has been merged.Resolution: LockedThis issue was locked by the bot.Resolution: PR SubmittedA pull request with a fix has been provided.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions