-
Notifications
You must be signed in to change notification settings - Fork 24.8k
Closed
Labels
Resolution: LockedThis issue was locked by the bot.This issue was locked by the bot.
Description
I've been messing around in my fork to try and understand the JS->Obj-C bridge, and the process for wrapping native code. I've wrapped CoreLocation in the WC3 Geolocation API as a first attempt.
I figured it would be great to get a bit of feedback on it, and some others might find it useful. It would be great if I could help document the process. I've got absolutely no Obj-C experience, so not sure if this is terrible or not.
Pull Request: JoeStanton#1
Metadata
Metadata
Assignees
Labels
Resolution: LockedThis issue was locked by the bot.This issue was locked by the bot.
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
nick commentedon Feb 4, 2015
Awesome - I'll give it a whirl on my Weather example. @vjeux mentioned that there is already a location API internally that they were planning on exposing soon - not sure what approach that will take.
vjeux commentedon Feb 5, 2015
Our API looks like that right now FYI
JoeStanton commentedon Feb 5, 2015
Thanks @vjeux. Good to know you're using a similar approach.
Is exposing Facebook's Geolocation API near-future or does it make sense to keep working on mine for now? I don't plan to get it merged as my Obj-C is probably awful. ;)
Also, would this belong in React Core?
vjeux commentedon Feb 5, 2015
We're going to port back our version to github soon, so we're unlikely going to use yours sorry :( I hope this was a good learning experience though. There's a bunch of other apis that will need to be bridged in a similar fashion so your skills won't be lost
JoeStanton commentedon Feb 5, 2015
Hah no worries! I knew it wouldn't. Was just for the learning experience. Maybe I can assist with writing some docs when you start, and yeah I'll look at other API's as and when I need them.
Merge pull request facebook#43 from davidxi/patch-1
JSONKit usage here may cause serious crash hard to debug(I found the …