Skip to content

Fix Travis podspec CI for Cxx bridge #14100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix Travis podspec CI for Cxx bridge #14100

wants to merge 2 commits into from

Conversation

javache
Copy link
Member

@javache javache commented May 22, 2017

Fixed the test script to properly setup our third-party deps and tweaked the third-party specs a bit so they work correctly.

This currently works for projects using static libraries, but fails when using dynamic libraries (--use-libraries)

cc @mhorowitz @alloy

@facebook-github-bot facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels May 22, 2017
@javache javache mentioned this pull request May 23, 2017
Closed
@javache javache force-pushed the javache-podspecs branch from 613f4a6 to e819299 Compare May 23, 2017 10:40
@javache
Copy link
Member Author

javache commented May 23, 2017

The build is stalling in untarring boost, which is also what I saw on my local machine when running this script.

@javache javache mentioned this pull request May 23, 2017
Closed
@javache javache force-pushed the javache-podspecs branch 2 times, most recently from 121d10d to 3ca7446 Compare May 23, 2017 15:31
ide
ide reviewed May 23, 2017
View reviewed changes
third-party-podspecs/GLog.podspec Outdated
@@ -6,12 +6,34 @@ Pod::Spec.new do |spec|
spec.summary = 'Google logging module'
spec.authors = 'Google'

# Keep in sync with ios-configure-glog.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure you want to do this, but just to put the idea out there -- since this file is just Ruby code, it can read from ios-configure-glog.sh or some other shared file so that the two don't need to manually be kept in sync.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I considered that. I guess if people install them through NPM we should have the same file available locally, but cocoapod's linting procedure may not copy these files over. I'll give it a try.

@javache javache force-pushed the javache-podspecs branch from 3ca7446 to f870009 Compare May 24, 2017 19:09
facebook-github-bot pushed a commit that referenced this pull request May 30, 2017
@javache @facebook-github-bot
Fix some issues with the React podspec for the Cxx bridge
33e2248 
Summary:
Trying to fix the RN Travis CI tests

Splitting off from #14100
Closes #14132

Reviewed By: ericvicenti

Differential Revision: D5112077

Pulled By: javache

fbshipit-source-id: cf030b927b0f28f2b494471498f1ddb2c0a5c1df
@javache javache force-pushed the javache-podspecs branch from f870009 to 78aa36b Compare May 31, 2017 20:17
@javache javache changed the title Fix podspecs for Cxx bridge Fix Travis podspec CI for Cxx bridge May 31, 2017
@javache javache mentioned this pull request Jun 6, 2017
Closed
@javache javache force-pushed the javache-podspecs branch from 78aa36b to c4d6c2e Compare June 23, 2017 19:46
@javache javache force-pushed the javache-podspecs branch from 6a84da4 to 3139a59 Compare June 30, 2017 23:11
@javache
Copy link
Member Author

javache commented Jul 1, 2017

Podspec run passes! https://travis-ci.org/facebook/react-native/jobs/248978123

@javache javache force-pushed the javache-podspecs branch 2 times, most recently from c65c8fb to 0f2d052 Compare July 3, 2017 11:24
@javache javache force-pushed the javache-podspecs branch from 0f2d052 to e7aa2a9 Compare July 7, 2017 08:16
@facebook-github-bot facebook-github-bot added GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. and removed GH Review: review-needed labels Jul 7, 2017
@facebook-github-bot
Copy link
Contributor

@javache has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@javache javache deleted the javache-podspecs branch July 7, 2017 09:40
ide pushed a commit that referenced this pull request Jul 7, 2017
@javache @ide
Fix Travis podspec CI for Cxx bridge
cc4fada 
Summary:
Fixed the test script to properly setup our third-party deps and tweaked the third-party specs a bit so they work correctly.

This currently works for projects using static libraries, but fails when using dynamic libraries (`--use-libraries`)

cc mhorowitz alloy
Closes #14100

Differential Revision: D5380728

Pulled By: javache

fbshipit-source-id: e78b6bd4466ebf2bf30b7e361eff10ec14b36a55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ide ide ide left review comments

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@javache @facebook-github-bot @ide @shergin