Skip to content

Fix Attempt to invoke virtual method 'void com.facebook.react.uimanager.ReactShadowNode.addChildAt(com.facebook.react.uimanager.ReactShadowNode, int)' on a null object reference #20079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix Attempt to invoke virtual method 'void com.facebook.react.uimanager.ReactShadowNode.addChildAt(com.facebook.react.uimanager.ReactShadowNode, int)' on a null object reference #20079

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions ReactAndroid/src/main/java/com/facebook/react/uimanager/UIImplementation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,12 +478,23 @@ public void setChildren(
ReadableArray childrenTags) {

ReactShadowNode cssNodeToManage = mShadowNodeRegistry.getNode(viewTag);
if (cssNodeToManage == null) {
FLog.w(
ReactConstants.TAG,
"Tried to add children to non-existent parent with tag " + viewTag
);
return;
}

for (int i = 0; i < childrenTags.size(); i++) {
ReactShadowNode cssNodeToAdd = mShadowNodeRegistry.getNode(childrenTags.getInt(i));
int childTag = childrenTags.getInt(i);
ReactShadowNode cssNodeToAdd = mShadowNodeRegistry.getNode(childTag);
if (cssNodeToAdd == null) {
throw new IllegalViewOperationException("Trying to add unknown view tag: "
+ childrenTags.getInt(i));
FLog.w(
ReactConstants.TAG,
"Tried to add a non-existent child with tag " + childTag + " to parent with tag " + viewTag
);
return;
}
cssNodeToManage.addChildAt(cssNodeToAdd, i);
}
Expand Down