Skip to content

Fix multiple calls to onMomentumScrollEnd when interrupted by dragging on Android #20304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+7 −0
Closed

Fix multiple calls to onMomentumScrollEnd when interrupted by dragging on Android #20304

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactScrollView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,8 @@ public boolean onInterceptTouchEvent(MotionEvent ev) {
NativeGestureUtil.notifyNativeGestureStarted(this, ev);
ReactScrollViewHelper.emitScrollBeginDragEvent(this);
mDragging = true;
mFlinging = false;
mDoneFlinging = false;
enableFpsListener();
return true;
}
Expand Down Expand Up @@ -300,6 +302,11 @@ public void fling(int velocityY) {
Runnable r = new Runnable() {
@Override
public void run() {
// It's possible the fling was interrupted by the user.
if (!mFlinging) {
return;
}

if (mDoneFlinging) {
mFlinging = false;
disableFpsListener();
Expand Down