[iOS] Fix isBatchActive of RCTCxxBridge #22785
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
There was a problem hiding this comment.
@cpojer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Hello @zhongwuzw, it seems like this was removed intentionally because it was both unused and can lead to wrong information due to races. Can you explain your use case and reasoning for why you brought it back and why we should include this in React Native again? Thank you. |
|
@cpojer Hi, Include this check can decrease layout process times because if there has batch calls, it would do layout end of it. |
|
Got it, I'm gonna land it since there are still references to it in the code. If somebody deems it not useful, I'll let them remove it in the future across the whole codebase. |
|
@zhongwuzw merged commit d55558e into |
matt-oakes
pushed a commit
to matt-oakes/react-native
that referenced
this pull request
Feb 7, 2019
Summary: Seems we lost handler of `isBatchActive` from [RCTBatchedBridge a86171a](https://github.com/facebook/react-native/blob/a86171a48284c440226a79a26c6d6a4704d401e9/React/Base/RCTBatchedBridge.m) to [RCTCxxBridge 5bc7e39](facebook@b774820#diff-a2a67635fffd7b690d14dc17ae563a71). Changelog: ---------- [iOS] [fixed] - Fix isBatchActive of RCTCxxBridge Pull Request resolved: facebook#22785 Reviewed By: mhorowitz Differential Revision: D13731897 Pulled By: cpojer fbshipit-source-id: 8d6b85bcea8fe8997a93b4e1ac8b8007422ca20e
aleclarson
pushed a commit
to aleclarson/react-native-macos
that referenced
this pull request
Feb 23, 2019
Summary: Seems we lost handler of `isBatchActive` from [RCTBatchedBridge a86171a](https://github.com/facebook/react-native/blob/a86171a48284c440226a79a26c6d6a4704d401e9/React/Base/RCTBatchedBridge.m) to [RCTCxxBridge 5bc7e39](facebook/react-native@b774820#diff-a2a67635fffd7b690d14dc17ae563a71). Changelog: ---------- [iOS] [fixed] - Fix isBatchActive of RCTCxxBridge Pull Request resolved: facebook/react-native#22785 Reviewed By: mhorowitz Differential Revision: D13731897 Pulled By: cpojer fbshipit-source-id: 8d6b85bcea8fe8997a93b4e1ac8b8007422ca20e
aleclarson
pushed a commit
to aleclarson/react-native-macos
that referenced
this pull request
Feb 27, 2019
Summary: Seems we lost handler of `isBatchActive` from [RCTBatchedBridge a86171a](https://github.com/facebook/react-native/blob/a86171a48284c440226a79a26c6d6a4704d401e9/React/Base/RCTBatchedBridge.m) to [RCTCxxBridge 5bc7e39](facebook/react-native@b774820#diff-a2a67635fffd7b690d14dc17ae563a71). Changelog: ---------- [iOS] [fixed] - Fix isBatchActive of RCTCxxBridge Pull Request resolved: facebook/react-native#22785 Reviewed By: mhorowitz Differential Revision: D13731897 Pulled By: cpojer fbshipit-source-id: 8d6b85bcea8fe8997a93b4e1ac8b8007422ca20e
aleclarson
pushed a commit
to aleclarson/react-native-macos
that referenced
this pull request
Feb 27, 2019
Summary: Seems we lost handler of `isBatchActive` from [RCTBatchedBridge a86171a](https://github.com/facebook/react-native/blob/a86171a48284c440226a79a26c6d6a4704d401e9/React/Base/RCTBatchedBridge.m) to [RCTCxxBridge 5bc7e39](facebook/react-native@b774820#diff-a2a67635fffd7b690d14dc17ae563a71). Changelog: ---------- [iOS] [fixed] - Fix isBatchActive of RCTCxxBridge Pull Request resolved: facebook/react-native#22785 Reviewed By: mhorowitz Differential Revision: D13731897 Pulled By: cpojer fbshipit-source-id: 8d6b85bcea8fe8997a93b4e1ac8b8007422ca20e
aleclarson
pushed a commit
to ptmt/react-native-macos
that referenced
this pull request
Feb 27, 2019
Summary: Seems we lost handler of `isBatchActive` from [RCTBatchedBridge a86171a](https://github.com/facebook/react-native/blob/a86171a48284c440226a79a26c6d6a4704d401e9/React/Base/RCTBatchedBridge.m) to [RCTCxxBridge 5bc7e39](facebook/react-native@b774820#diff-a2a67635fffd7b690d14dc17ae563a71). Changelog: ---------- [iOS] [fixed] - Fix isBatchActive of RCTCxxBridge Pull Request resolved: facebook/react-native#22785 Reviewed By: mhorowitz Differential Revision: D13731897 Pulled By: cpojer fbshipit-source-id: 8d6b85bcea8fe8997a93b4e1ac8b8007422ca20e
aleclarson
pushed a commit
to ptmt/react-native-macos
that referenced
this pull request
Feb 27, 2019
Summary: Seems we lost handler of `isBatchActive` from [RCTBatchedBridge a86171a](https://github.com/facebook/react-native/blob/a86171a48284c440226a79a26c6d6a4704d401e9/React/Base/RCTBatchedBridge.m) to [RCTCxxBridge 5bc7e39](facebook/react-native@b774820#diff-a2a67635fffd7b690d14dc17ae563a71). Changelog: ---------- [iOS] [fixed] - Fix isBatchActive of RCTCxxBridge Pull Request resolved: facebook/react-native#22785 Reviewed By: mhorowitz Differential Revision: D13731897 Pulled By: cpojer fbshipit-source-id: 8d6b85bcea8fe8997a93b4e1ac8b8007422ca20e
enigmaticsoul216
added a commit
to enigmaticsoul216/RN_macos
that referenced
this pull request
Feb 2, 2025
Summary: Seems we lost handler of `isBatchActive` from [RCTBatchedBridge a86171a](https://github.com/facebook/react-native/blob/a86171a48284c440226a79a26c6d6a4704d401e9/React/Base/RCTBatchedBridge.m) to [RCTCxxBridge 5bc7e39](facebook/react-native@b774820#diff-a2a67635fffd7b690d14dc17ae563a71). Changelog: ---------- [iOS] [fixed] - Fix isBatchActive of RCTCxxBridge Pull Request resolved: facebook/react-native#22785 Reviewed By: mhorowitz Differential Revision: D13731897 Pulled By: cpojer fbshipit-source-id: 8d6b85bcea8fe8997a93b4e1ac8b8007422ca20e
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems we lost handler of
isBatchActivefrom RCTBatchedBridge a86171a to RCTCxxBridge 5bc7e39.Changelog:
[iOS] [fixed] - Fix isBatchActive of RCTCxxBridge
Test Plan:
isBatchActivealways equal toNObefore thisPR, after it, if batched message is being invoked,isBatchActiveequal toYES.