Fixed - Text with adjustsFontSizeToFit changes the text layout infinitely

[alfonsocj]

Summary

Fixes the infinite loop explained in the issue #33129 by reverting commit 5902152. PR #31538.

onCollectExtraUpdates is part of the node update cycle. By marking the node as updated markUpdated() in onCollectExtraUpdates we are restarting the update infinitely.

Unfortunately, reverting this PR also reintroduces the original issue #30717 which IMO is minor compared to the infinite loop.

Changelog

[Android] [Fixed] - Text with adjustsFontSizeToFit changes the text layout infinitely

Test Plan

I added a console.log to the Text onTextLayout in packages/rn-tester/js/examples/Text/TextAdjustsDynamicLayoutExample.js to see if the infinite loop is gone.

[facebook-github-bot]

Hi @alfonsocj!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[shergin]

Yeah, as the author of the original fix (being reverted here), I believe we should back it out because it introduces way more problems than solves.

[shergin]

@lunaleaps hey, hey! if you are still managing the release process, I believe it should be added to a patch version. 🙇

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[lunaleaps]

Hey @shergin! Glad to hear from you! Sounds good, I'll put it as a comment on our releases discussion group. It's where we generally make cherry-picks for stable/pre-release now!

[facebook-github-bot]

@lunaleaps has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[alfonsocj]

Thanks @lunaleaps! Can we also try to include this fix in the discussion for 0.66.5? I'm not sure if you fix previous versions as well.

[react-native-bot]

This pull request was successfully merged by Alfonso Curbelo in c1db41f.

^{When will my fix make it into a release? | Upcoming Releases}

[lunaleaps]

Thanks @lunaleaps! Can we also try to include this fix in the discussion for 0.66.5? I'm not sure if you fix previous versions as well.

Generally no, we usually only target the current stable or release candidate.

[Orange9000]

Is there a way to apply this fix without upgrading react-native? I tried patching react-native package, but that doesn't seem to do anything, as if module remains unchanged.