Remove incorrect const constraint from UIManager commit hooks #37588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D46149085 |
Base commit: ff849fd |
|
This pull request was exported from Phabricator. Differential Revision: D46149085 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
May 26, 2023
…ok#37588) Summary: Pull Request resolved: facebook#37588 The `const` modified in UIManagerCommitHook prevents us from mutating the commit hook itself (which doesn't make any sense as commit hooks might want to update their internal state as response to new commits). This removes the constraint so we can remove the `const` modifier from `MutationObserverManager` in D46149086. Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D46149085 fbshipit-source-id: c258fc3b8a2800db720cc5609a90f15f9b03536c
rubennorte
force-pushed
the
export-D46149085
branch
from
6acfab7 to
2de19c9
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
May 26, 2023
…ok#37588) Summary: Pull Request resolved: facebook#37588 The `const` modified in UIManagerCommitHook prevents us from mutating the commit hook itself (which doesn't make any sense as commit hooks might want to update their internal state as response to new commits). This removes the constraint so we can remove the `const` modifier from `MutationObserverManager` in a future diff. Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D46149085 fbshipit-source-id: c834b950132b3a9e0b7ddeec0156ff8bc9d87245
rubennorte
force-pushed
the
export-D46149085
branch
from
2de19c9 to
84b562b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46149085 |
…that works with an ancestor list Differential Revision: D45866232 fbshipit-source-id: ee2f834eca3cee9966ac94007bfecb211b8401ec
…le on a parent node Differential Revision: D45866231 fbshipit-source-id: 047b562d3c2800689bbf48427f88e7e8b9e85653
…to layout metrics Differential Revision: D45866245 fbshipit-source-id: 63b63a465599d575db2ffc079db8300af1195188
Differential Revision: D45916675 fbshipit-source-id: 0a196eb5dc335264618da52b2076008817b67451
Differential Revision: D45866244 fbshipit-source-id: 8ed328e60fa16a9bb45e029f28d50b992a87177c
…ok#37588) Summary: Pull Request resolved: facebook#37588 The `const` modified in UIManagerCommitHook prevents us from mutating the commit hook itself (which doesn't make any sense as commit hooks might want to update their internal state as response to new commits). This removes the constraint so we can remove the `const` modifier from `MutationObserverManager` in a future diff. Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D46149085 fbshipit-source-id: e348479c4b5b3d864f7be9133588b0a5eedc8452
rubennorte
force-pushed
the
export-D46149085
branch
from
84b562b to
3caac1a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46149085 |
|
This pull request has been merged in 3afb5b8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The
constmodified in UIManagerCommitHook prevents us from mutating the commit hook itself (which doesn't make any sense as commit hooks might want to update their internal state as response to new commits).This removes the constraint so we can remove the
constmodifier fromMutationObserverManagerin D46149086.Changelog: [internal]
Reviewed By: sammy-SC
Differential Revision: D46149085