fix: declare missing dependency chalk
#42235
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Base commit: 8fd2f12 |
|
@cortinico merged this pull request in 9155e2d. |
gokul1099
pushed a commit
to gokul1099/react-native-visionos
that referenced
this pull request
Jan 17, 2024
Summary: Dependency on `chalk` was introduced in facebook#37510, but was never declared. In pnpm setups, the CLI fails to run because of this. This needs to be picked to 0.73. ## Changelog: [GENERAL] [FIXED] - Declare missing dependency `chalk` Pull Request resolved: facebook#42235 Test Plan: n/a Reviewed By: huntie Differential Revision: D52660337 Pulled By: cortinico fbshipit-source-id: 1cd45fcff72045c127773566a27103f1b38262b3
blakef
pushed a commit
that referenced
this pull request
Jan 25, 2024
Summary: Dependency on `chalk` was introduced in #37510, but was never declared. In pnpm setups, the CLI fails to run because of this. This needs to be picked to 0.73. [GENERAL] [FIXED] - Declare missing dependency `chalk` Pull Request resolved: #42235 Test Plan: n/a Reviewed By: huntie Differential Revision: D52660337 Pulled By: cortinico fbshipit-source-id: 1cd45fcff72045c127773566a27103f1b38262b3
This was referenced Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Dependency on
chalkwas introduced in #37510, but was never declared. In pnpm setups, the CLI fails to run because of this.This needs to be picked to 0.73.
Changelog:
[GENERAL] [FIXED] - Declare missing dependency
chalkTest Plan:
n/a