iOS Codegen: bring back support for defining external libraries in react-native.config.js #42771
+47
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D53267857 |
Base commit: 7b36233 |
…act-native.config.js (facebook#42771) Summary: This feature was first introduced here facebook#34580 And then removed here facebook#41654 The motivation for its removing was that Node resolver should handle all those cases for which `react-native.config.js` was used. But it turns out that it fails for the setup that `react-native-builder-bob` has. This diff brings back support for defining external libraries in `react-native.config.js`. Changelog: [iOS][Fixed] - Bring back support for defining external libraries in react-native.config.js Reviewed By: cipolleschi Differential Revision: D53267857
dmytrorykun
force-pushed
the
export-D53267857
branch
from
ebd4042 to
ec8a5cb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53267857 |
|
This pull request has been merged in c6c2304. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This feature was first introduced here #34580
And then removed here #41654
The motivation for its removing was that Node resolver should handle all those cases for which
react-native.config.jswas used. But it turns out that it fails for the setup thatreact-native-builder-bobhas.This diff brings back support for defining external libraries in
react-native.config.js.Changelog: [iOS][Fixed] - Bring back support for defining external libraries in react-native.config.js
Differential Revision: D53267857