Skip to content

[iOS][Fix] Add missing lock around assignment of cancellation handler in RCTImageLoader #45454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+2 −0
Closed

[iOS][Fix] Add missing lock around assignment of cancellation handler in RCTImageLoader #45454

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/react-native/Libraries/Image/RCTImageLoader.mm
View file
Original file line number Diff line number Diff line change
@@ -840,7 +840,9 @@ - (RCTImageURLLoaderRequest *)loadImageWithURLRequest:(NSURLRequest *)imageURLRe
progressBlock:progressBlock
partialLoadBlock:partialLoadBlock
completionBlock:completionHandler];
[cancelLoadLock lock];
cancelLoad = loaderRequest.cancellationBlock;
[cancelLoadLock unlock];
return [[RCTImageURLLoaderRequest alloc] initWithRequestId:loaderRequest.requestId
imageURL:imageURLRequest.URL
cancellationBlock:cancellationBlock];
Loading