Skip to content

[iOS][Fixed] Use std::atomic for eliminating races in RCTCxxBridge #45558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[iOS][Fixed] Use std::atomic for eliminating races in RCTCxxBridge #45558

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions packages/react-native/React/CxxBridge/RCTCxxBridge.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ void onBatchComplete() override

@implementation RCTCxxBridge {
BOOL _didInvalidate;
BOOL _moduleRegistryCreated;
std::atomic<BOOL> _moduleRegistryCreated;

NSMutableArray<RCTPendingCall> *_pendingCalls;
std::atomic<NSInteger> _pendingCount;
Expand All @@ -220,12 +220,28 @@ @implementation RCTCxxBridge {
RCTViewRegistry *_viewRegistry_DEPRECATED;
RCTBundleManager *_bundleManager;
RCTCallableJSModules *_callableJSModules;
std::atomic<BOOL> _loading;
std::atomic<BOOL> _valid;
}

@synthesize bridgeDescription = _bridgeDescription;
@synthesize loading = _loading;
@synthesize performanceLogger = _performanceLogger;
@synthesize valid = _valid;

-(BOOL)isLoading {
return _loading;
}

-(void)setLoading:(BOOL)newValue {
_loading = newValue;
}

-(BOOL)isValid {
return _valid;
}

-(void)setValid:(BOOL)newValue {
_valid = newValue;
}

- (RCTModuleRegistry *)moduleRegistry
{
Expand Down