Skip to content

[iOS] Fabric: Fixes assert failure when surface stop before we start surface #48213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[iOS] Fabric: Fixes assert failure when surface stop before we start surface #48213

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80e31b3
[iOS] Fabric: Fixes assert failure when surface stop before we start …
zhongwuzw Dec 11, 2024
fcdc14f
Add the comment
zhongwuzw Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/react-native/ReactCommon/react/runtime/platform/ios/ReactCommon/RCTHost.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,9 @@ - (RCTFabricSurface *)createSurfaceWithModuleName:(NSString *)moduleName
surface.surfaceHandler.setDisplayMode(displayMode);
[self _attachSurface:surface];

[_instance callFunctionOnBufferedRuntimeExecutor:[surface](facebook::jsi::Runtime &_) { [surface start]; }];
__weak RCTFabricSurface *weakSurface = surface;
// Use the BufferedRuntimeExecutor to start the surface after the main JS bundle was fully executed.
[_instance callFunctionOnBufferedRuntimeExecutor:[weakSurface](facebook::jsi::Runtime &_) { [weakSurface start]; }];
return surface;
}

Expand Down
Loading