Skip to content

[iOS] Fabric: Fixes Numeric TextInput not triggering onSubmitEditing #48276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[iOS] Fabric: Fixes Numeric TextInput not triggering onSubmitEditing #48276

wants to merge 1 commit into from

Conversation

zhongwuzw
Copy link
Contributor

Summary:

Fixes #48259 . The paper code like :

react-native/packages/react-native/Libraries/Text/TextInput/RCTBaseTextInputView.mm

Lines 777 to 784 in 2fee130

- (void)handleInputAccessoryDoneButton
{
// Ignore the value of whether we submitted; just make sure the submit event is called if necessary.
[self textInputShouldSubmitOnReturn];
if ([self textInputShouldReturn]) {
[self.backedTextInputView endEditing:YES];
}
}

Changelog:

[IOS] [FIXED] - Fabric: Fixes Numeric TextInput not triggering onSubmitEditing

Test Plan:

Repro in #48259

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 16, 2024
@zhongwuzw zhongwuzw mentioned this pull request Dec 16, 2024
Closed
@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Dec 16, 2024
@facebook-github-bot
Copy link
Contributor

@javache has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@javache merged this pull request in 5d67490.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Dec 16, 2024
@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @zhongwuzw in 5d67490

When will my fix make it into a release? | How to file a pick request?

@okanisildar okanisildar mentioned this pull request Dec 28, 2024
Closed
robhogan pushed a commit that referenced this pull request Dec 30, 2024
@zhongwuzw @robhogan
Fabric: Fixes Numeric TextInput not triggering onSubmitEditing (#48276)
0bcb0c2 
Summary:
Fixes #48259 . The paper code like :
https://github.com/facebook/react-native/blob/2fee13094b3d384c071978776fd8b7cff0b6530f/packages/react-native/Libraries/Text/TextInput/RCTBaseTextInputView.mm#L777-L784

## Changelog:

[IOS] [FIXED] - Fabric: Fixes Numeric TextInput not triggering onSubmitEditing

Pull Request resolved: #48276

Test Plan: Repro in #48259

Reviewed By: cipolleschi

Differential Revision: D67274739

Pulled By: javache

fbshipit-source-id: 57396c6e1a8ef96a1b29cae4a9aa9b5f48f6080b
@cipolleschi cipolleschi mentioned this pull request Jan 14, 2025
Closed
@cipolleschi cipolleschi mentioned this pull request Feb 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[iOS][NewArch] Numeric TextInput not triggering onSubmitEditing

3 participants

@zhongwuzw @facebook-github-bot @react-native-bot