Add scheduleTask and runWorkLoop to public API #48284
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67275518 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Dec 16, 2024
Summary: Changelog: [internal] We recently prevented tasks that run via `runTask` to synchronously call `runTask` because the execution is synchronous and we can't nest tasks in the event loop (D67107664 / facebook#48235). This adds `scheduleTask` to schedule tasks (also within tasks) with the right expectations (the task will not run synchronously on that call but at the right time). It also adds `runWorkLoop` so we can run scheduled tasks if they're not scheduled from an already running task. Differential Revision: D67275518
rubennorte
force-pushed
the
export-D67275518
branch
from
42325f7 to
f3c747f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67275518 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Dec 16, 2024
Summary: Changelog: [internal] We recently prevented tasks that run via `runTask` to synchronously call `runTask` because the execution is synchronous and we can't nest tasks in the event loop (D67107664 / facebook#48235). This adds `scheduleTask` to schedule tasks (also within tasks) with the right expectations (the task will not run synchronously on that call but at the right time). It also adds `runWorkLoop` so we can run scheduled tasks if they're not scheduled from an already running task. Differential Revision: D67275518
rubennorte
force-pushed
the
export-D67275518
branch
from
f3c747f to
3efdc72
Compare
Summary: Changelog: [internal] We recently prevented tasks that run via `runTask` to synchronously call `runTask` because the execution is synchronous and we can't nest tasks in the event loop (D67107664 / facebook#48235). This adds `scheduleTask` to schedule tasks (also within tasks) with the right expectations (the task will not run synchronously on that call but at the right time). It also adds `runWorkLoop` so we can run scheduled tasks if they're not scheduled from an already running task. Differential Revision: D67275518
|
This pull request was exported from Phabricator. Differential Revision: D67275518 |
rubennorte
force-pushed
the
export-D67275518
branch
from
3efdc72 to
6e282b7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67275518 |
|
This pull request has been merged in 358fd38. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
We recently prevented tasks that run via
runTaskto synchronously callrunTaskbecause the execution is synchronous and we can't nest tasks in the event loop (D67107664 / #48235).This adds
scheduleTaskto schedule tasks (also within tasks) with the right expectations (the task will not run synchronously on that call but at the right time).It also adds
runWorkLoopso we can run scheduled tasks if they're not scheduled from an already running task.Differential Revision: D67275518