RN: Fix Typing for Non-Boolean Feature Flags #51707
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D75690997 |
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
May 30, 2025
Summary: Currently, the type definitions for feature flags assumes `boolean` values in the `expectedReleaseValue` field. This diff fixes them so `expectedReleaseValue` must match the type of `defaultValue`. Changelog: [Internal] Differential Revision: D75690997
yungsters
force-pushed
the
export-D75690997
branch
from
a04d625 to
020f598
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75690997 |
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
May 30, 2025
Summary: Currently, the type definitions for feature flags assumes `boolean` values in the `expectedReleaseValue` field. This diff fixes them so `expectedReleaseValue` must match the type of `defaultValue`. Changelog: [Internal] Differential Revision: D75690997
Summary: Currently, the feature flag system does not properly support non-boolean feature flags. The type definitions and generated code make assumptions about the value type being `boolean`. This diff fixes these assumptions so that non-boolean feature flags are supported. Changelog: [Internal] Differential Revision: D75690997
yungsters
force-pushed
the
export-D75690997
branch
from
020f598 to
4481aa1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75690997 |
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
May 30, 2025
Summary: Currently, the feature flag system does not properly support non-boolean feature flags. The type definitions and generated code make assumptions about the value type being `boolean`. This diff fixes these assumptions so that non-boolean feature flags are supported. Changelog: [Internal] Differential Revision: D75690997
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
May 30, 2025
Summary: Pull Request resolved: facebook#51707 Currently, the feature flag system does not properly support non-boolean feature flags. The type definitions and generated code make assumptions about the value type being `boolean`. This diff fixes these assumptions so that non-boolean feature flags are supported. Changelog: [Internal] Differential Revision: D75690997
|
This pull request has been merged in 8343045. |
|
This pull request was successfully merged by @yungsters in 8343045 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Currently, the type definitions for feature flags assumes
booleanvalues in theexpectedReleaseValuefield.This diff fixes them so
expectedReleaseValuemust match the type ofdefaultValue.Changelog:
[Internal]
Differential Revision: D75690997