Remove continue-on-error from e2e test in GHA #51746
Closed
+0
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: I observed that when continue-on-error is set to true, Github reports the outcome of a job as success even if it fails. With this change, we should ensure that when an E2E test fails, the pipeline fails, so that we can retry the jobs properly. ## Changelog: [Internal] - Remove continue-on-error from e2e tests in GHA Differential Revision: D75796284
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D75796284 |
|
This pull request has been merged in f2c9d74. |
|
This pull request was successfully merged by @cipolleschi in f2c9d74 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I observed that when continue-on-error is set to true, Github reports the outcome of a job as success even if it fails.
With this change, we should ensure that when an E2E test fails, the pipeline fails, so that we can retry the jobs properly.
Changelog:
[Internal] - Remove continue-on-error from e2e tests in GHA
Differential Revision: D75796284