[Local] Fix CI for 0.79-stable #51804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
cipolleschi
force-pushed
the
cipolleschi/79-fix-ci
branch
9 times, most recently
from
8b5b094 to
aaf080d
Compare
cipolleschi
force-pushed
the
cipolleschi/79-fix-ci
branch
from
aaf080d to
67bb783
Compare
Summary: Pull Request resolved: #51382 This diff replaces `dtslint` which is obsolete and [It is not intended to be used on its own, but as part of the definitelytyped set of packages](https://github.com/microsoft/dtslint) in favor of `tsc` type tests. It's probably not necessary to have `test-typescript-offline` as tsc does that out of the box but doesn't test with multiple TS versions. Changelog: [Internal] Reviewed By: huntie Differential Revision: D74804967 fbshipit-source-id: 4c581ba5debf6fd0bb8dcddbb95f3c85b05082d4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
CI got broken after a cherry pick went wrong. This PR should fix it.
Changelog:
[Internal] -
Test Plan:
GHa