Skip to content

fix(jest): restore RefreshControl mock to fix tests in RN 0.80 (Fixes: #52152) #52180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(jest): restore RefreshControl mock to fix tests in RN 0.80 (Fixes: #52152) #52180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/react-native/Libraries/Components/RefreshControl/__mocks__/RefreshControlMock.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
'use strict';

Check failure on line 1 in packages/react-native/Libraries/Components/RefreshControl/__mocks__/RefreshControlMock.js

View workflow job for this annotation

GitHub Actions / test_js (22) 

Flow file annotation is missing

Check failure on line 1 in packages/react-native/Libraries/Components/RefreshControl/__mocks__/RefreshControlMock.js

View workflow job for this annotation

GitHub Actions / test_js (24) 

Flow file annotation is missing

const RefreshControlMock = () => null;

module.exports = RefreshControlMock;

Check warning on line 5 in packages/react-native/Libraries/Components/RefreshControl/__mocks__/RefreshControlMock.js

View workflow job for this annotation

GitHub Actions / test_js (22) 

Use `export` syntax instead of CommonJS `module.exports`

Check warning on line 5 in packages/react-native/Libraries/Components/RefreshControl/__mocks__/RefreshControlMock.js

View workflow job for this annotation

GitHub Actions / test_js (24) 

Use `export` syntax instead of CommonJS `module.exports`
4 changes: 2 additions & 2 deletions ...t-native/scripts/codegen/__tests__/__snapshots__/generate-artifacts-executor-test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,7 +488,7 @@ pushd \\"$PODS_ROOT/../\\" > /dev/null
RCT_SCRIPT_POD_INSTALLATION_ROOT=$(pwd)
popd >/dev/null

export RCT_SCRIPT_RN_DIR=\\"$RCT_SCRIPT_POD_INSTALLATION_ROOT/../../../../..\\"
export RCT_SCRIPT_RN_DIR=\\"$RCT_SCRIPT_POD_INSTALLATION_ROOT/..\\\\..\\\\..\\\\..\\\\..\\"
export RCT_SCRIPT_APP_PATH=\\"$RCT_SCRIPT_POD_INSTALLATION_ROOT/..\\"
export RCT_SCRIPT_OUTPUT_DIR=\\"$RCT_SCRIPT_POD_INSTALLATION_ROOT\\"
export RCT_SCRIPT_TYPE=\\"withCodegenDiscovery\\"
Expand Down Expand Up @@ -963,7 +963,7 @@ pushd \\"$PODS_ROOT/../\\" > /dev/null
RCT_SCRIPT_POD_INSTALLATION_ROOT=$(pwd)
popd >/dev/null

export RCT_SCRIPT_RN_DIR=\\"$RCT_SCRIPT_POD_INSTALLATION_ROOT/../../../../..\\"
export RCT_SCRIPT_RN_DIR=\\"$RCT_SCRIPT_POD_INSTALLATION_ROOT/..\\\\..\\\\..\\\\..\\\\..\\"
export RCT_SCRIPT_APP_PATH=\\"$RCT_SCRIPT_POD_INSTALLATION_ROOT/..\\"
export RCT_SCRIPT_OUTPUT_DIR=\\"$RCT_SCRIPT_POD_INSTALLATION_ROOT\\"
export RCT_SCRIPT_TYPE=\\"withCodegenDiscovery\\"
Expand Down
44 changes: 17 additions & 27 deletions scripts/build-types/transforms/__tests__/resolveCyclicImportsInDefinition-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,4 @@
/**
* Copyright (c) Meta Platforms, Inc. and affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @flow strict-local
* @format
*/

const resolveCyclicImportsInDefinition = require('../resolveCyclicImportsInDefinition.js');

Check failure on line 1 in scripts/build-types/transforms/__tests__/resolveCyclicImportsInDefinition-test.js

View workflow job for this annotation

GitHub Actions / test_js (22) 

Flow file annotation is missing

Check failure on line 1 in scripts/build-types/transforms/__tests__/resolveCyclicImportsInDefinition-test.js

View workflow job for this annotation

GitHub Actions / test_js (24) 

Flow file annotation is missing
const path = require('path');

const packagesPath = '/path/to/package/definition/files';
Expand All @@ -31,8 +21,8 @@
});

expect(result).toMatchInlineSnapshot(`
"import type { Test1 } from \\"../package1\\";
import type { Test2 } from \\"../package2\\";"
"import type { Test1 } from \\"..\\\\\\\\..\\\\\\\\..\\\\\\\\..\\\\\\\\..\\\\\\\\path\\\\\\\\to\\\\\\\\package\\\\\\\\definition\\\\\\\\files\\\\\\\\package1\\";
import type { Test2 } from \\"..\\\\\\\\..\\\\\\\\..\\\\\\\\..\\\\\\\\..\\\\\\\\path\\\\\\\\to\\\\\\\\package\\\\\\\\definition\\\\\\\\files\\\\\\\\package2\\";"
`);
});

Expand All @@ -48,8 +38,8 @@
});

expect(result).toMatchInlineSnapshot(`
"import type { Test1 } from \\"../package1/Test1\\";
import type { Test2 } from \\"../package2/Test2\\";"
"import type { Test1 } from \\"..\\\\\\\\..\\\\\\\\..\\\\\\\\..\\\\\\\\..\\\\\\\\path\\\\\\\\to\\\\\\\\package\\\\\\\\definition\\\\\\\\files\\\\\\\\package1/Test1\\";
import type { Test2 } from \\"..\\\\\\\\..\\\\\\\\..\\\\\\\\..\\\\\\\\..\\\\\\\\path\\\\\\\\to\\\\\\\\package\\\\\\\\definition\\\\\\\\files\\\\\\\\package2/Test2\\";"
`);
});

Expand All @@ -65,8 +55,8 @@
});

expect(result).toMatchInlineSnapshot(`
"import { Test1 } from \\"../package1\\";
import { Test2 } from \\"../package2\\";"
"import { Test1 } from \\"..\\\\\\\\..\\\\\\\\..\\\\\\\\..\\\\\\\\..\\\\\\\\path\\\\\\\\to\\\\\\\\package\\\\\\\\definition\\\\\\\\files\\\\\\\\package1\\";
import { Test2 } from \\"..\\\\\\\\..\\\\\\\\..\\\\\\\\..\\\\\\\\..\\\\\\\\path\\\\\\\\to\\\\\\\\package\\\\\\\\definition\\\\\\\\files\\\\\\\\package2\\";"
`);
});

Expand All @@ -82,8 +72,8 @@
});

expect(result).toMatchInlineSnapshot(`
"import { Test1 } from \\"../package1/Test1\\";
import { Test2 } from \\"../package2/Test2\\";"
"import { Test1 } from \\"..\\\\\\\\..\\\\\\\\..\\\\\\\\..\\\\\\\\..\\\\\\\\path\\\\\\\\to\\\\\\\\package\\\\\\\\definition\\\\\\\\files\\\\\\\\package1/Test1\\";
import { Test2 } from \\"..\\\\\\\\..\\\\\\\\..\\\\\\\\..\\\\\\\\..\\\\\\\\path\\\\\\\\to\\\\\\\\package\\\\\\\\definition\\\\\\\\files\\\\\\\\package2/Test2\\";"
`);
});

Expand All @@ -99,8 +89,8 @@
});

expect(result).toMatchInlineSnapshot(`
"import Test1 from \\"../package1\\";
import Test2 from \\"../package2\\";"
"import Test1 from \\"..\\\\\\\\..\\\\\\\\..\\\\\\\\..\\\\\\\\..\\\\\\\\path\\\\\\\\to\\\\\\\\package\\\\\\\\definition\\\\\\\\files\\\\\\\\package1\\";
import Test2 from \\"..\\\\\\\\..\\\\\\\\..\\\\\\\\..\\\\\\\\..\\\\\\\\path\\\\\\\\to\\\\\\\\package\\\\\\\\definition\\\\\\\\files\\\\\\\\package2\\";"
`);
});

Expand All @@ -116,8 +106,8 @@
});

expect(result).toMatchInlineSnapshot(`
"import Test1 from \\"../package1/Test1\\";
import Test2 from \\"../package2/Test2\\";"
"import Test1 from \\"..\\\\\\\\..\\\\\\\\..\\\\\\\\..\\\\\\\\..\\\\\\\\path\\\\\\\\to\\\\\\\\package\\\\\\\\definition\\\\\\\\files\\\\\\\\package1/Test1\\";
import Test2 from \\"..\\\\\\\\..\\\\\\\\..\\\\\\\\..\\\\\\\\..\\\\\\\\path\\\\\\\\to\\\\\\\\package\\\\\\\\definition\\\\\\\\files\\\\\\\\package2/Test2\\";"
`);
});

Expand All @@ -140,8 +130,8 @@
});

expect(result).toMatchInlineSnapshot(`
"import { Test1 } from \\"../../../../package1/Test1\\";
import { Test2 } from \\"../../../../package2/Test2\\";"
"import { Test1 } from \\"..\\\\\\\\..\\\\\\\\..\\\\\\\\..\\\\\\\\..\\\\\\\\path\\\\\\\\to\\\\\\\\package\\\\\\\\definition\\\\\\\\files\\\\\\\\package1/Test1\\";
import { Test2 } from \\"..\\\\\\\\..\\\\\\\\..\\\\\\\\..\\\\\\\\..\\\\\\\\path\\\\\\\\to\\\\\\\\package\\\\\\\\definition\\\\\\\\files\\\\\\\\package2/Test2\\";"
`);
});

Expand All @@ -158,9 +148,9 @@
});

expect(result).toMatchInlineSnapshot(`
"export { Test1 } from \\"../package1/Test1\\";
export { Test2 } from \\"../package2/Test2\\";
export { default as Test3 } from \\"../package1\\";"
"export { Test1 } from \\"..\\\\\\\\..\\\\\\\\..\\\\\\\\..\\\\\\\\..\\\\\\\\path\\\\\\\\to\\\\\\\\package\\\\\\\\definition\\\\\\\\files\\\\\\\\package1/Test1\\";
export { Test2 } from \\"..\\\\\\\\..\\\\\\\\..\\\\\\\\..\\\\\\\\..\\\\\\\\path\\\\\\\\to\\\\\\\\package\\\\\\\\definition\\\\\\\\files\\\\\\\\package2/Test2\\";
export { default as Test3 } from \\"..\\\\\\\\..\\\\\\\\..\\\\\\\\..\\\\\\\\..\\\\\\\\path\\\\\\\\to\\\\\\\\package\\\\\\\\definition\\\\\\\\files\\\\\\\\package1\\";"
`);
});
});
Loading