Improve EmbeddedApp.md docs wrt location of ReactComponent (also minor formatting) #552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It might be too chatty for people just starting out, but I can see why people might want it.
Hopefully this helps people how simple the process is!
It doesn’t seem like a good practice to tell people to create their custom ReactComponent directory inside of the Pods/ directory. The Pods/ directory should be limited to CocoaPods installed content, and it’s not even accepted across the board to [check this stuff into git][1] Therefore, let’s tune the EmbeddableApp tutorial to instruct users to create a ReactComponent directory at the root of their project. From there, we’ll start the development server packager to source that directory as a JS files root. This change also improves starting this packager server, proxying the command through npm. [1]: https://github.com/github/gitignore/blob/5883804e6ceb0867e88dc8ca1c7585fa61e40797/Objective-C.gitignore#L20-L26
I think this helps identify classes and code files as opposed to emphasized prose.
vjeux
added a commit
that referenced
this pull request
Mar 31, 2015
Improve EmbeddedApp.md docs wrt location of ReactComponent (also minor formatting)
|
Thanks, looks much better :) |
|
Thanks! It looks wonderful :) To be honest, I am a iOS newbie. So thanks for your update, learnt a lot! |
jfrolich
pushed a commit
to jfrolich/react-native
that referenced
this pull request
Apr 22, 2020
ayushjainrksh
referenced
this pull request
in MLH-Fellowship/react-native
Jul 2, 2020
Greetings component example in procs.md didnn't have enclosing jsx tag and thus failed, this is to fix that.
This was referenced Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds off of the awesome work from @tjwudi to expand on the embedded app docs when using @CocoaPods.
ReactComponentdirectory as a sibling of their existing app code, and not in thePods/directory where third-party dependencies are installedPods/directory should solely be managed by CocoaPods and not include any custom app content