-
Notifications
You must be signed in to change notification settings - Fork 24.7k
fixed jest tests: added /website/ folder to jest ignore list #6170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Don't merge it until Monday, giving a chance to merge a large diff with as little number of conflicts |
Why do you have a website folder in jest-cli? Did you npm link the github repo? I guess I'm not opposed to this change but it isn't something you are going to run into as a user of react-native. It only happens when you work on react-native and jest. And you link it. This happened to me before, so it makes sense. I would recommend changing the pattern to |
@cpojer, the website folder is in the root of repo. |
21217c2
to
e15315b
Compare
@bestander updated the pull request. |
oh, you mean the react-native website. That makes sense, |
👍 |
e15315b
to
667fd6e
Compare
@bestander updated the pull request. |
@facebook-github-bot shipit |
Thanks for importing. If you are an FB employee go to Phabricator to review. |
@facebook-github-bot shipit |
Thanks for importing. If you are an FB employee go to Phabricator to review. |
667fd6e
to
2193028
Compare
@facebook-github-bot shipit |
@bestander updated the pull request. |
Thanks for importing. If you are an FB employee go to Phabricator to review. |
@bestander Looks legit 👍 |
If website has node_modules installed
npm tests
Test plan (required)
Before this fix we see this error:
Error: Failed to build DependencyGraph: @providesModule naming collision:
Duplicate module name: ViewportMetrics
Paths: react-native/node_modules/react/lib/ViewportMetrics.js collides with react-native/website/node_modules/react/lib/ViewportMetrics.js