-
Notifications
You must be signed in to change notification settings - Fork 24.7k
Added HackerWeb App to website showcase #6244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
By analyzing the blame information on this pull request, we identified @brentvatne, @chirag04 and @mkonicek to be potential reviewers. |
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
@facebook-github-bot shipit |
@chirag04 do we have to shipit again? |
yeah. I think the import failed. you want to give it a go one more time? |
Yeah, let's try 🎱 @facebook-github-bot shipit |
@facebook-github-bot shipit |
Something's up, don't see anything in the cron job logs. Will use this PR as a test case for debugging. |
Please don't add more comments so I can use this PR for testing :) @cheeaun We'll eventually merge this, either using the bot or manually. Thanks for the patience. |
@mkonicek cool, thanks! 👍😁 |
@facebook-github-bot shipit |
just checking :) |
@facebook-github-bot shipit |
Thanks for importing. If you are an FB employee go to Phabricator to review. |
OK the issue is that the PR summary contained an emoji which the import doesn't support. |
@cheeaun updated the pull request. |
@facebook-github-bot shipit |
Thanks for importing. If you are an FB employee go to Phabricator to review. |
Adding my HackerWeb iOS app to the app showcase.