Skip to content

Added HackerWeb App to website showcase #6244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

cheeaun
Copy link
Contributor

@cheeaun cheeaun commented Mar 2, 2016

Adding my HackerWeb iOS app to the app showcase.

@facebook-github-bot
Copy link
Contributor

By analyzing the blame information on this pull request, we identified @brentvatne, @chirag04 and @mkonicek to be potential reviewers.

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 2, 2016
@chirag04
Copy link
Contributor

chirag04 commented Mar 2, 2016

@facebook-github-bot shipit

@grabbou
Copy link
Contributor

grabbou commented Mar 3, 2016

@chirag04 do we have to shipit again?

@chirag04
Copy link
Contributor

chirag04 commented Mar 3, 2016

yeah. I think the import failed. you want to give it a go one more time?

@grabbou
Copy link
Contributor

grabbou commented Mar 3, 2016

Yeah, let's try 🎱

@facebook-github-bot shipit

@mkonicek
Copy link
Contributor

mkonicek commented Mar 3, 2016

@facebook-github-bot shipit

@mkonicek
Copy link
Contributor

mkonicek commented Mar 3, 2016

Something's up, don't see anything in the cron job logs. Will use this PR as a test case for debugging.

@mkonicek
Copy link
Contributor

mkonicek commented Mar 3, 2016

Please don't add more comments so I can use this PR for testing :)

@cheeaun We'll eventually merge this, either using the bot or manually. Thanks for the patience.
If you're interested in what the @facebook-github-bot shipit does under the hood, check out this presentation I made: https://speakerdeck.com/mkonicek/under-the-hood-of-react-native?slide=45

@cheeaun
Copy link
Contributor Author

cheeaun commented Mar 4, 2016

@mkonicek cool, thanks! 👍😁

@bestander
Copy link
Contributor

@facebook-github-bot shipit

@bestander
Copy link
Contributor

just checking :)

@mkonicek
Copy link
Contributor

mkonicek commented Mar 8, 2016

@facebook-github-bot shipit

@facebook-github-bot
Copy link
Contributor

Thanks for importing. If you are an FB employee go to Phabricator to review.

@mkonicek
Copy link
Contributor

mkonicek commented Mar 8, 2016

OK the issue is that the PR summary contained an emoji which the import doesn't support.

@facebook-github-bot
Copy link
Contributor

@cheeaun updated the pull request.

@mkonicek
Copy link
Contributor

@facebook-github-bot shipit

@facebook-github-bot
Copy link
Contributor

Thanks for importing. If you are an FB employee go to Phabricator to review.

@ghost ghost closed this in dcfa620 Mar 10, 2016
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants