iOS Text - Modify "onChange" behaviour to allow for all changes in contentSize

[deanmcpherson]

As per discussion with @nicklockwood and @brentvatne on #1229. This PR is an initial attempt to satisfy the following:

1. Only call onChange once per set of changes (e.g. if text and contentSize both change at once - which is usually the case - we should only fire one onChange event)
2. Only call onChange if something has actually changed (i.e. don't fire it unconditionally in updateContentSize if updateContentSize sometimes gets called when the contentSize hasn't changed).

This change is necessary to allow for auto height scaling on TextInputs that adjust when the value is modified outside of user input.

[facebook-github-bot]

By analyzing the blame information on this pull request, we identified @nicklockwood, @sahrens and @brentvatne to be potential reviewers.

[brentvatne]

@kmagiera - we need to mirror this behaviour on Android too, cc @mkonicek @bestander

[brentvatne]

I did a quick implementation of onChangeContentSize on Android as per @nicklockwood's comment (#1229 (comment)). I need this so I'll integrate it into Exponent right away but if someone wants to bring this in to a pull request for both iOS and Android, go for it - https://github.com/exponentjs/react-native/pull/3/files
cc @deanmcpherson

[facebook-github-bot]

@deanmcpherson updated the pull request.

[facebook-github-bot]

@deanmcpherson updated the pull request.

[mkonicek]

we need to mirror this behaviour on Android too

@brentvatne OK, someone should send a PR for that once this one lands.

[ghost]

@nicklockwood would you mind taking a look at this pull request? It's been a while since the last commit was reviewed.

[mkonicek]

@majak Are you familiar with TextViews on iOS?

[majak]

Looks reasonable.
@facebook-github-bot shipit

[ide]

@facebook-github-bot shipit

[facebook-github-bot]

Thanks for importing. If you are a Facebook employee, you can view this diff on Phabricator.

[brentvatne]

cc @janicduplessis

[facebook-github-bot]

I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification.

[hramos]

Please resolve the conflicts in RCTTextView.m

[lacker]

@deanmcpherson Are you still working on this? If not perhaps we should just close the pull request.

[deanmcpherson]

Hey @lacker,

No sorry, im not working on this. Happy for it to be closed.