Skip to content

Documentation: Fix LayoutWithFlexbox.md broken example #8608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Documentation: Fix LayoutWithFlexbox.md broken example #8608

wants to merge 1 commit into from

Conversation

valscion
Copy link
Contributor

@valscion valscion commented Jul 6, 2016 •
edited
Loading

This fixes the Align Items example in Layout with Flexbox -documentation page by fixing a broken example.

screen shot 2016-07-06 at 20 59 08

EDIT: Seems like 34adde9 tried to cover all of these but missed one case :)

@ghost
Copy link

ghost commented Jul 6, 2016

By analyzing the blame information on this pull request, we identified @dabbott and @JoelMarcey to be potential reviewers.

@ghost ghost added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jul 6, 2016
@valscion
Copy link
Contributor Author

valscion commented Jul 6, 2016

I tried to test this change locally as told in CONTRIBUTING.md but I wasn't able to view any doc pages after having ran npm start from scratch:

ReferenceError: Unknown plugin "transform-flow-strip-types" specified in "base" at 0, attempted to resolve relative to "."
    at /Users/vesa/code/muut/react-native/website/node_modules/babel-core/lib/transformation/file/options/option-manager.js:204:17
    at Array.map (native)
    at Function.normalisePlugins (/Users/vesa/code/muut/react-native/website/node_modules/babel-core/lib/transformation/file/options/option-manager.js:180:20)
    at OptionManager.mergeOptions (/Users/vesa/code/muut/react-native/website/node_modules/babel-core/lib/transformation/file/options/option-manager.js:300:36)
    at OptionManager.init (/Users/vesa/code/muut/react-native/website/node_modules/babel-core/lib/transformation/file/options/option-manager.js:488:10)
    at File.initOptions (/Users/vesa/code/muut/react-native/website/node_modules/babel-core/lib/transformation/file/index.js:223:65)
    at new File (/Users/vesa/code/muut/react-native/website/node_modules/babel-core/lib/transformation/file/index.js:140:24)
    at Pipeline.transform (/Users/vesa/code/muut/react-native/website/node_modules/babel-core/lib/transformation/pipeline.js:46:16)
    at parseAPIJsDocFormat (/Users/vesa/code/muut/react-native/website/server/extractDocs.js:280:22)
    at renderAPI (/Users/vesa/code/muut/react-native/website/server/extractDocs.js:418:21)
Error: ENOENT: no such file or directory, open '/Users/vesa/code/muut/react-native/website/src/elements/favicon/favicon.ico'
    at Error (native)

screen shot 2016-07-06 at 21 12 12

@JoelMarcey
Copy link

Thanks @valscion!

@JoelMarcey
Copy link

@facebook-github-bot shipit

@ghost ghost added GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. and removed GH Review: review-needed labels Jul 6, 2016
@facebook-github-bot
Copy link
Contributor

Thanks for importing. If you are an FB employee go to Phabricator to review.

@ghost ghost closed this in 3a24c63 Jul 6, 2016
bubblesunyum pushed a commit to iodine/react-native that referenced this pull request Aug 23, 2016
@valscion @bubblesunyum
Documentation: Fix LayoutWithFlexbox.md broken example
ef9844d 
Summary:
This fixes the [Align Items example](http://facebook.github.io/react-native/releases/next/docs/flexbox.html#align-items) in Layout with Flexbox -documentation page by fixing a broken example.

<img width="892" alt="screen shot 2016-07-06 at 20 59 08" src="https://cloud.githubusercontent.com/assets/482561/16629040/ee0e819e-43bc-11e6-8ca1-eb9b90869b59.png">

EDIT: Seems like 34adde9 tried to cover all of these but missed one case :)
Closes facebook#8608

Differential Revision: D3523445

Pulled By: JoelMarcey

fbshipit-source-id: ffc8be2b2e85d3b821a37e387e9385e57820a200
mpretty-cyro pushed a commit to HomePass/react-native that referenced this pull request Aug 25, 2016
@valscion
Documentation: Fix LayoutWithFlexbox.md broken example
97cef58 
Summary:
This fixes the [Align Items example](http://facebook.github.io/react-native/releases/next/docs/flexbox.html#align-items) in Layout with Flexbox -documentation page by fixing a broken example.

<img width="892" alt="screen shot 2016-07-06 at 20 59 08" src="https://cloud.githubusercontent.com/assets/482561/16629040/ee0e819e-43bc-11e6-8ca1-eb9b90869b59.png">

EDIT: Seems like 34adde9 tried to cover all of these but missed one case :)
Closes facebook#8608

Differential Revision: D3523445

Pulled By: JoelMarcey

fbshipit-source-id: ffc8be2b2e85d3b821a37e387e9385e57820a200
tungdo194 pushed a commit to tungdo194/rn-test that referenced this pull request Apr 28, 2024
@valscion @seraj-ahmad
Documentation: Fix LayoutWithFlexbox.md broken example
d95b664 
Summary:
This fixes the [Align Items example](http://facebook.github.io/react-native/releases/next/docs/flexbox.html#align-items) in Layout with Flexbox -documentation page by fixing a broken example.

<img width="892" alt="screen shot 2016-07-06 at 20 59 08" src="https://cloud.githubusercontent.com/assets/482561/16629040/ee0e819e-43bc-11e6-8ca1-eb9b90869b59.png">

EDIT: Seems like 34adde9 tried to cover all of these but missed one case :)
Closes facebook/react-native#8608

Differential Revision: D3523445

Pulled By: JoelMarcey

fbshipit-source-id: ffc8be2b2e85d3b821a37e387e9385e57820a200
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@valscion @JoelMarcey @facebook-github-bot