Fix the yeoman-environment version #8614
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! |
|
Actually, I think I signed the CLA two years ago. Anyway. Should be oki now. |
The release of 1.6.2 of yoman-environment break react-native (since there is no lib folder) Yeoman will be removed from RN as facebook#8197 anyway. This closes facebook#8610. Thanks @cpsubrian
tychota
force-pushed
the
fix-yeaoman-version
branch
from
dee78a7 to
3ef5e77
Compare
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
ghost
added
the
CLA Signed
|
Rebased it on top of upstream/master |
|
@facebook-github-bot shipit cc @grabbou we need to release 0.29.1 |
tychota
changed the title
|
@facebook-github-bot shipit |
ghost
added
GH Review: accepted
Import Started
|
Thanks for importing. If you are an FB employee go to Phabricator to review. |
|
@satya164 : maybe no more necessary :) It don't harm to merge this anyway (my first PR ^^) but maybe a 0.29.1 is not necessary. |
|
@tychota Can't cancel it now. So let it merge :) |
bubblesunyum
pushed a commit
to iodine/react-native
that referenced
this pull request
Aug 23, 2016
Summary: This closes facebook#8610. The release of 1.6.2 of yeoman-environment break react-native (since there is no lib folder) Yeoman will be removed from RN as facebook#8197 anyway. Thanks cpsubrian, RobTS **Test plan (required)** I installed the 1.2.7 version and copied it in react-native nodes_modules. Then I ran react-native upgrade <img width="1337" alt="screen shot 2016-07-06 at 21 09 33" src="https://cloud.githubusercontent.com/assets/13785185/16631160/075fc422-43be-11e6-8625-92f03075b007.png"> Closes facebook#8614 Differential Revision: D3524043 fbshipit-source-id: 1def4854ca0fd881b8a935f37c86eb373dfd97c5
mpretty-cyro
pushed a commit
to HomePass/react-native
that referenced
this pull request
Aug 25, 2016
Summary: This closes facebook#8610. The release of 1.6.2 of yeoman-environment break react-native (since there is no lib folder) Yeoman will be removed from RN as facebook#8197 anyway. Thanks cpsubrian, RobTS **Test plan (required)** I installed the 1.2.7 version and copied it in react-native nodes_modules. Then I ran react-native upgrade <img width="1337" alt="screen shot 2016-07-06 at 21 09 33" src="https://cloud.githubusercontent.com/assets/13785185/16631160/075fc422-43be-11e6-8625-92f03075b007.png"> Closes facebook#8614 Differential Revision: D3524043 fbshipit-source-id: 1def4854ca0fd881b8a935f37c86eb373dfd97c5
tungdo194
pushed a commit
to tungdo194/rn-test
that referenced
this pull request
Apr 28, 2024
Summary: This closes #8610. The release of 1.6.2 of yeoman-environment break react-native (since there is no lib folder) Yeoman will be removed from RN as #8197 anyway. Thanks cpsubrian, RobTS **Test plan (required)** I installed the 1.2.7 version and copied it in react-native nodes_modules. Then I ran react-native upgrade <img width="1337" alt="screen shot 2016-07-06 at 21 09 33" src="https://cloud.githubusercontent.com/assets/13785185/16631160/075fc422-43be-11e6-8625-92f03075b007.png"> Closes facebook/react-native#8614 Differential Revision: D3524043 fbshipit-source-id: 1def4854ca0fd881b8a935f37c86eb373dfd97c5
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #8610.
The release of 1.6.2 of yeoman-environment break react-native (since there is no lib folder)
Yeoman will be removed from RN as #8197 anyway.
Thanks @cpsubrian, @RobTS
Test plan (required)
I installed the 1.2.7 version and copied it in react-native nodes_modules.
Then I ran react-native upgrade