-
Notifications
You must be signed in to change notification settings - Fork 24.7k
Add dep for android local unit tests #8957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
By analyzing the blame information on this pull request, we identified @michalgr to be a potential reviewer. |
It is a bit strange that cxx bridge now depends on bridge? |
@bestander Maybe it related with a parallel building?
|
Yes, you are right, @deminoth. |
@facebook-github-bot shipit |
Thanks for importing. If you are an FB employee go to Phabricator to review internal test results. |
Summary: `./scripts/run-android-local-unit-tests.sh` raise error ``` 05: error: cannot access com.facebook.react.bridge.CatalystInstance verify(mCatalystInstanceImpl).loadScriptFromOptimizedBundle( ^ class file for com.facebook.react.bridge.CatalystInstance not found ``` and this PR fix it. Closes facebook#8957 Differential Revision: D3613491 Pulled By: bestander fbshipit-source-id: 53b52fca13482e6474d7ffec9c19c0e7d6e4d100
./scripts/run-android-local-unit-tests.sh
raise errorand this PR fix it.