Skip to content

Add dep for android local unit tests #8957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

deminoth
Copy link
Contributor

./scripts/run-android-local-unit-tests.sh raise error

05: error: cannot access com.facebook.react.bridge.CatalystInstance
    verify(mCatalystInstanceImpl).loadScriptFromOptimizedBundle(
                                 ^
  class file for com.facebook.react.bridge.CatalystInstance not found

and this PR fix it.

@ghost
Copy link

ghost commented Jul 22, 2016

By analyzing the blame information on this pull request, we identified @michalgr to be a potential reviewer.

@ghost ghost added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jul 22, 2016
@ide
Copy link
Contributor

ide commented Jul 22, 2016

cc @bestander @mhorowitz

@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 22, 2016
@bestander
Copy link
Contributor

It is a bit strange that cxx bridge now depends on bridge?
How come it runs in CI?

@deminoth
Copy link
Contributor Author

@bestander Maybe it related with a parallel building?

cto:react-native bono$ ./scripts/run-android-local-unit-tests.sh
Fetching dependencies...
Using watchman.
[-] PROCESSING BUCK FILES...FINISHED 0.9s [100%]
[-] DOWNLOADING... (0.00 B/S AVG, TOTAL: 0.00 B, 0 Artifacts)
[-] BUILDING...FINISHED 2.4s [100%] (53/53 JOBS, 0 UPDATED, 0.0% CACHE MISS)
Running unit tests...
[-] PROCESSING BUCK FILES...FINISHED 0.3s [100%]
[+] DOWNLOADING... (0.00 B/S, TOTAL: 0.00 B, 0 Artifacts)
[+] BUILDING...14.1s [31%] (231/238 JOBS, 41 UPDATED, 5.0% CACHE MISS)
 |=> //ReactAndroid/src/test/java/com/facebook/react/animated:animated...  0.7s (checking local cache)
 |=> //ReactAndroid/src/test/java/com/facebook/react/uimanager:uimanager...  0.8s (running javac[0.5s])
 |=> //ReactAndroid/src/test/java/com/facebook/react/cxxbridge:bridge...  2.1s (running javac[1.2s])
 |=> //ReactAndroid/src/test/java/com/facebook/react/bridge:bridge...  1.1s (running javac[0.4s])
/Users/bono/repo/react-native/ReactAndroid/src/test/java/com/facebook/react/cxxbridge/UnpackingJSBundleLoaderTest.java:105: error: cannot access com.facebook.react.bridge.CatalystInstance
    verify(mCatalystInstanceImpl).loadScriptFromOptimizedBundle(
                                 ^
  class file for com.facebook.react.bridge.CatalystInstance not found
Errors: 1. Warnings: 0.

Rule //ReactAndroid/src/test/java/com/facebook/react/cxxbridge:bridge has failed to build.
com.facebook.react.bridge.CatalystInstance
Try adding the following deps:
//ReactAndroid/src/main/java/com/facebook/react/bridge:bridge

@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 25, 2016
@bestander
Copy link
Contributor

Yes, you are right, @deminoth.
Thanks for the PR.
Any ideas why Circle CI is green and passes the test?

@bestander
Copy link
Contributor

@facebook-github-bot shipit

@ghost ghost added GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. and removed GH Review: review-needed labels Jul 25, 2016
@ghost
Copy link

ghost commented Jul 25, 2016

Thanks for importing. If you are an FB employee go to Phabricator to review internal test results.

@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 25, 2016
@ghost ghost closed this in d06bea4 Jul 25, 2016
mpretty-cyro pushed a commit to HomePass/react-native that referenced this pull request Aug 25, 2016
Summary:
`./scripts/run-android-local-unit-tests.sh` raise error
```
05: error: cannot access com.facebook.react.bridge.CatalystInstance
    verify(mCatalystInstanceImpl).loadScriptFromOptimizedBundle(
                                 ^
  class file for com.facebook.react.bridge.CatalystInstance not found
```
and this PR fix it.
Closes facebook#8957

Differential Revision: D3613491

Pulled By: bestander

fbshipit-source-id: 53b52fca13482e6474d7ffec9c19c0e7d6e4d100
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants