Skip to content

Commit 893bdf0

Browse files
jackpopejackpope
committed
Set renameElementSymbol to dynamic value (#30066)
Prepare to roll this out with dynamic flag `yarn flags --diff www canary` <img width="514" alt="Screenshot 2024-06-24 at 11 33 55 AM" src="https://github.com/facebook/react/assets/8965173/31508fdc-4cb1-4ce0-8e22-c02a034377b0"> DiffTrain build for [89580f2](89580f2)
1 parent ae90e9f commit 893bdf0

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

42 files changed

+292
-158
lines changed

‎compiled/facebook-www/JSXDEVRuntime-dev.classic.js

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -811,8 +811,12 @@ __DEV__ &&
811811
disableDefaultPropsExceptForClasses =
812812
dynamicFeatureFlags.disableDefaultPropsExceptForClasses,
813813
enableFastJSX = dynamicFeatureFlags.enableFastJSX,
814-
disableLegacyMode = dynamicFeatureFlags.disableLegacyMode,
815-
REACT_ELEMENT_TYPE = Symbol.for("react.element"),
814+
renameElementSymbol = dynamicFeatureFlags.renameElementSymbol,
815+
disableLegacyMode = dynamicFeatureFlags.disableLegacyMode;
816+
dynamicFeatureFlags = Symbol.for("react.element");
817+
var REACT_ELEMENT_TYPE = renameElementSymbol
818+
? Symbol.for("react.transitional.element")
819+
: dynamicFeatureFlags,
816820
REACT_PORTAL_TYPE = Symbol.for("react.portal"),
817821
REACT_FRAGMENT_TYPE = Symbol.for("react.fragment"),
818822
REACT_STRICT_MODE_TYPE = Symbol.for("react.strict_mode"),

‎compiled/facebook-www/JSXDEVRuntime-dev.modern.js

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -806,9 +806,13 @@ __DEV__ &&
806806
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing,
807807
enableRenderableContext = dynamicFeatureFlags.enableRenderableContext,
808808
disableDefaultPropsExceptForClasses =
809-
dynamicFeatureFlags.disableDefaultPropsExceptForClasses;
810-
dynamicFeatureFlags = dynamicFeatureFlags.enableFastJSX;
811-
var REACT_ELEMENT_TYPE = Symbol.for("react.element"),
809+
dynamicFeatureFlags.disableDefaultPropsExceptForClasses,
810+
enableFastJSX = dynamicFeatureFlags.enableFastJSX;
811+
dynamicFeatureFlags = dynamicFeatureFlags.renameElementSymbol;
812+
var REACT_LEGACY_ELEMENT_TYPE = Symbol.for("react.element"),
813+
REACT_ELEMENT_TYPE = dynamicFeatureFlags
814+
? Symbol.for("react.transitional.element")
815+
: REACT_LEGACY_ELEMENT_TYPE,
812816
REACT_PORTAL_TYPE = Symbol.for("react.portal"),
813817
REACT_FRAGMENT_TYPE = Symbol.for("react.fragment"),
814818
REACT_STRICT_MODE_TYPE = Symbol.for("react.strict_mode"),
@@ -853,7 +857,7 @@ __DEV__ &&
853857
specialPropKeyWarningShown;
854858
var didWarnAboutStringRefs = {};
855859
var didWarnAboutElementRef = {};
856-
var enableFastJSXWithStringRefs = dynamicFeatureFlags && !0,
860+
var enableFastJSXWithStringRefs = enableFastJSX && !0,
857861
enableFastJSXWithoutStringRefs = enableFastJSXWithStringRefs && !1,
858862
didWarnAboutKeySpread = {},
859863
ownerHasKeyUseWarning = {};

‎compiled/facebook-www/REVISION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
c21bcd627b6a8f31548edfc149dd3b879fea6558
1+
89580f209ce68ae9e266e309dfeb1625b434fb58

‎compiled/facebook-www/REVISION_TRANSFORMS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
c21bcd627b6a8f31548edfc149dd3b879fea6558
1+
89580f209ce68ae9e266e309dfeb1625b434fb58

‎compiled/facebook-www/React-dev.classic.js

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1199,8 +1199,12 @@ __DEV__ &&
11991199
disableDefaultPropsExceptForClasses =
12001200
dynamicFeatureFlags.disableDefaultPropsExceptForClasses,
12011201
enableFastJSX = dynamicFeatureFlags.enableFastJSX,
1202+
renameElementSymbol = dynamicFeatureFlags.renameElementSymbol,
12021203
disableLegacyMode = dynamicFeatureFlags.disableLegacyMode,
1203-
REACT_ELEMENT_TYPE = Symbol.for("react.element"),
1204+
REACT_LEGACY_ELEMENT_TYPE = Symbol.for("react.element"),
1205+
REACT_ELEMENT_TYPE = renameElementSymbol
1206+
? Symbol.for("react.transitional.element")
1207+
: REACT_LEGACY_ELEMENT_TYPE,
12041208
REACT_PORTAL_TYPE = Symbol.for("react.portal"),
12051209
REACT_FRAGMENT_TYPE = Symbol.for("react.fragment"),
12061210
REACT_STRICT_MODE_TYPE = Symbol.for("react.strict_mode"),
@@ -1987,7 +1991,7 @@ __DEV__ &&
19871991
exports.useTransition = function () {
19881992
return resolveDispatcher().useTransition();
19891993
};
1990-
exports.version = "19.0.0-www-classic-c21bcd627b-20240624";
1994+
exports.version = "19.0.0-www-classic-89580f209c-20240624";
19911995
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
19921996
"function" ===
19931997
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled/facebook-www/React-dev.modern.js

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1196,7 +1196,11 @@ __DEV__ &&
11961196
disableDefaultPropsExceptForClasses =
11971197
dynamicFeatureFlags.disableDefaultPropsExceptForClasses,
11981198
enableFastJSX = dynamicFeatureFlags.enableFastJSX,
1199-
REACT_ELEMENT_TYPE = Symbol.for("react.element"),
1199+
renameElementSymbol = dynamicFeatureFlags.renameElementSymbol,
1200+
REACT_LEGACY_ELEMENT_TYPE = Symbol.for("react.element"),
1201+
REACT_ELEMENT_TYPE = renameElementSymbol
1202+
? Symbol.for("react.transitional.element")
1203+
: REACT_LEGACY_ELEMENT_TYPE,
12001204
REACT_PORTAL_TYPE = Symbol.for("react.portal"),
12011205
REACT_FRAGMENT_TYPE = Symbol.for("react.fragment"),
12021206
REACT_STRICT_MODE_TYPE = Symbol.for("react.strict_mode"),
@@ -1967,7 +1971,7 @@ __DEV__ &&
19671971
exports.useTransition = function () {
19681972
return resolveDispatcher().useTransition();
19691973
};
1970-
exports.version = "19.0.0-www-modern-c21bcd627b-20240624";
1974+
exports.version = "19.0.0-www-modern-89580f209c-20240624";
19711975
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
19721976
"function" ===
19731977
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled/facebook-www/React-prod.classic.js

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,11 @@ var dynamicFeatureFlags = require("ReactFeatureFlags"),
1717
disableDefaultPropsExceptForClasses =
1818
dynamicFeatureFlags.disableDefaultPropsExceptForClasses,
1919
enableFastJSX = dynamicFeatureFlags.enableFastJSX,
20+
renameElementSymbol = dynamicFeatureFlags.renameElementSymbol,
2021
REACT_LEGACY_ELEMENT_TYPE = Symbol.for("react.element"),
22+
REACT_ELEMENT_TYPE = renameElementSymbol
23+
? Symbol.for("react.transitional.element")
24+
: REACT_LEGACY_ELEMENT_TYPE,
2125
REACT_PORTAL_TYPE = Symbol.for("react.portal"),
2226
REACT_FRAGMENT_TYPE = Symbol.for("react.fragment"),
2327
REACT_STRICT_MODE_TYPE = Symbol.for("react.strict_mode"),
@@ -98,7 +102,7 @@ var enableFastJSXWithStringRefs = enableFastJSX && !0,
98102
function ReactElement(type, key, _ref, self, source, owner, props) {
99103
_ref = props.ref;
100104
return {
101-
$$typeof: REACT_LEGACY_ELEMENT_TYPE,
105+
$$typeof: REACT_ELEMENT_TYPE,
102106
type: type,
103107
key: key,
104108
ref: void 0 !== _ref ? _ref : null,
@@ -145,7 +149,7 @@ function isValidElement(object) {
145149
return (
146150
"object" === typeof object &&
147151
null !== object &&
148-
object.$$typeof === REACT_LEGACY_ELEMENT_TYPE
152+
object.$$typeof === REACT_ELEMENT_TYPE
149153
);
150154
}
151155
function coerceStringRef(mixedRef, owner, type) {
@@ -242,7 +246,7 @@ function mapIntoArray(children, array, escapedPrefix, nameSoFar, callback) {
242246
break;
243247
case "object":
244248
switch (children.$$typeof) {
245-
case REACT_LEGACY_ELEMENT_TYPE:
249+
case REACT_ELEMENT_TYPE:
246250
case REACT_PORTAL_TYPE:
247251
invokeCallback = !0;
248252
break;
@@ -665,4 +669,4 @@ exports.useSyncExternalStore = function (
665669
exports.useTransition = function () {
666670
return ReactSharedInternals.H.useTransition();
667671
};
668-
exports.version = "19.0.0-www-classic-c21bcd627b-20240624";
672+
exports.version = "19.0.0-www-classic-89580f209c-20240624";

‎compiled/facebook-www/React-prod.modern.js

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,11 @@ var dynamicFeatureFlags = require("ReactFeatureFlags"),
1717
disableDefaultPropsExceptForClasses =
1818
dynamicFeatureFlags.disableDefaultPropsExceptForClasses,
1919
enableFastJSX = dynamicFeatureFlags.enableFastJSX,
20+
renameElementSymbol = dynamicFeatureFlags.renameElementSymbol,
2021
REACT_LEGACY_ELEMENT_TYPE = Symbol.for("react.element"),
22+
REACT_ELEMENT_TYPE = renameElementSymbol
23+
? Symbol.for("react.transitional.element")
24+
: REACT_LEGACY_ELEMENT_TYPE,
2125
REACT_PORTAL_TYPE = Symbol.for("react.portal"),
2226
REACT_FRAGMENT_TYPE = Symbol.for("react.fragment"),
2327
REACT_STRICT_MODE_TYPE = Symbol.for("react.strict_mode"),
@@ -98,7 +102,7 @@ var enableFastJSXWithStringRefs = enableFastJSX && !0,
98102
function ReactElement(type, key, _ref, self, source, owner, props) {
99103
_ref = props.ref;
100104
return {
101-
$$typeof: REACT_LEGACY_ELEMENT_TYPE,
105+
$$typeof: REACT_ELEMENT_TYPE,
102106
type: type,
103107
key: key,
104108
ref: void 0 !== _ref ? _ref : null,
@@ -145,7 +149,7 @@ function isValidElement(object) {
145149
return (
146150
"object" === typeof object &&
147151
null !== object &&
148-
object.$$typeof === REACT_LEGACY_ELEMENT_TYPE
152+
object.$$typeof === REACT_ELEMENT_TYPE
149153
);
150154
}
151155
function coerceStringRef(mixedRef, owner, type) {
@@ -242,7 +246,7 @@ function mapIntoArray(children, array, escapedPrefix, nameSoFar, callback) {
242246
break;
243247
case "object":
244248
switch (children.$$typeof) {
245-
case REACT_LEGACY_ELEMENT_TYPE:
249+
case REACT_ELEMENT_TYPE:
246250
case REACT_PORTAL_TYPE:
247251
invokeCallback = !0;
248252
break;
@@ -665,4 +669,4 @@ exports.useSyncExternalStore = function (
665669
exports.useTransition = function () {
666670
return ReactSharedInternals.H.useTransition();
667671
};
668-
exports.version = "19.0.0-www-modern-c21bcd627b-20240624";
672+
exports.version = "19.0.0-www-modern-89580f209c-20240624";

‎compiled/facebook-www/React-profiling.classic.js

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,11 @@ var dynamicFeatureFlags = require("ReactFeatureFlags"),
2121
disableDefaultPropsExceptForClasses =
2222
dynamicFeatureFlags.disableDefaultPropsExceptForClasses,
2323
enableFastJSX = dynamicFeatureFlags.enableFastJSX,
24+
renameElementSymbol = dynamicFeatureFlags.renameElementSymbol,
2425
REACT_LEGACY_ELEMENT_TYPE = Symbol.for("react.element"),
26+
REACT_ELEMENT_TYPE = renameElementSymbol
27+
? Symbol.for("react.transitional.element")
28+
: REACT_LEGACY_ELEMENT_TYPE,
2529
REACT_PORTAL_TYPE = Symbol.for("react.portal"),
2630
REACT_FRAGMENT_TYPE = Symbol.for("react.fragment"),
2731
REACT_STRICT_MODE_TYPE = Symbol.for("react.strict_mode"),
@@ -102,7 +106,7 @@ var enableFastJSXWithStringRefs = enableFastJSX && !0,
102106
function ReactElement(type, key, _ref, self, source, owner, props) {
103107
_ref = props.ref;
104108
return {
105-
$$typeof: REACT_LEGACY_ELEMENT_TYPE,
109+
$$typeof: REACT_ELEMENT_TYPE,
106110
type: type,
107111
key: key,
108112
ref: void 0 !== _ref ? _ref : null,
@@ -149,7 +153,7 @@ function isValidElement(object) {
149153
return (
150154
"object" === typeof object &&
151155
null !== object &&
152-
object.$$typeof === REACT_LEGACY_ELEMENT_TYPE
156+
object.$$typeof === REACT_ELEMENT_TYPE
153157
);
154158
}
155159
function coerceStringRef(mixedRef, owner, type) {
@@ -246,7 +250,7 @@ function mapIntoArray(children, array, escapedPrefix, nameSoFar, callback) {
246250
break;
247251
case "object":
248252
switch (children.$$typeof) {
249-
case REACT_LEGACY_ELEMENT_TYPE:
253+
case REACT_ELEMENT_TYPE:
250254
case REACT_PORTAL_TYPE:
251255
invokeCallback = !0;
252256
break;
@@ -669,7 +673,7 @@ exports.useSyncExternalStore = function (
669673
exports.useTransition = function () {
670674
return ReactSharedInternals.H.useTransition();
671675
};
672-
exports.version = "19.0.0-www-classic-c21bcd627b-20240624";
676+
exports.version = "19.0.0-www-classic-89580f209c-20240624";
673677
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
674678
"function" ===
675679
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled/facebook-www/React-profiling.modern.js

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,11 @@ var dynamicFeatureFlags = require("ReactFeatureFlags"),
2121
disableDefaultPropsExceptForClasses =
2222
dynamicFeatureFlags.disableDefaultPropsExceptForClasses,
2323
enableFastJSX = dynamicFeatureFlags.enableFastJSX,
24+
renameElementSymbol = dynamicFeatureFlags.renameElementSymbol,
2425
REACT_LEGACY_ELEMENT_TYPE = Symbol.for("react.element"),
26+
REACT_ELEMENT_TYPE = renameElementSymbol
27+
? Symbol.for("react.transitional.element")
28+
: REACT_LEGACY_ELEMENT_TYPE,
2529
REACT_PORTAL_TYPE = Symbol.for("react.portal"),
2630
REACT_FRAGMENT_TYPE = Symbol.for("react.fragment"),
2731
REACT_STRICT_MODE_TYPE = Symbol.for("react.strict_mode"),
@@ -102,7 +106,7 @@ var enableFastJSXWithStringRefs = enableFastJSX && !0,
102106
function ReactElement(type, key, _ref, self, source, owner, props) {
103107
_ref = props.ref;
104108
return {
105-
$$typeof: REACT_LEGACY_ELEMENT_TYPE,
109+
$$typeof: REACT_ELEMENT_TYPE,
106110
type: type,
107111
key: key,
108112
ref: void 0 !== _ref ? _ref : null,
@@ -149,7 +153,7 @@ function isValidElement(object) {
149153
return (
150154
"object" === typeof object &&
151155
null !== object &&
152-
object.$$typeof === REACT_LEGACY_ELEMENT_TYPE
156+
object.$$typeof === REACT_ELEMENT_TYPE
153157
);
154158
}
155159
function coerceStringRef(mixedRef, owner, type) {
@@ -246,7 +250,7 @@ function mapIntoArray(children, array, escapedPrefix, nameSoFar, callback) {
246250
break;
247251
case "object":
248252
switch (children.$$typeof) {
249-
case REACT_LEGACY_ELEMENT_TYPE:
253+
case REACT_ELEMENT_TYPE:
250254
case REACT_PORTAL_TYPE:
251255
invokeCallback = !0;
252256
break;
@@ -669,7 +673,7 @@ exports.useSyncExternalStore = function (
669673
exports.useTransition = function () {
670674
return ReactSharedInternals.H.useTransition();
671675
};
672-
exports.version = "19.0.0-www-modern-c21bcd627b-20240624";
676+
exports.version = "19.0.0-www-modern-89580f209c-20240624";
673677
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
674678
"function" ===
675679
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

0 commit comments

Comments
 (0)