Skip to content

Set renameElementSymbol to dynamic value #30066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 24, 2024
Merged

Set renameElementSymbol to dynamic value #30066

merged 3 commits into from
Jun 24, 2024

Conversation

jackpope
Copy link
Member

Prepare to roll this out with dynamic flag

yarn flags --diff www canary

Screenshot 2024-06-24 at 11 33 55 AM

@vercel Vercel
Copy link

vercel bot commented Jun 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 24, 2024 4:18pm

@facebook-github-bot facebook-github-bot added the React Core Team Opened by a member of the React Core Team label Jun 24, 2024
@react-sizebot
Copy link

react-sizebot commented Jun 24, 2024 •
edited
Loading

Comparing: c21bcd6...284e05d

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.05% 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 497.93 kB 497.93 kB = 89.26 kB 89.26 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 502.75 kB 502.75 kB = 89.96 kB 89.96 kB
facebook-www/ReactDOM-prod.classic.js +0.03% 596.94 kB 597.10 kB +0.04% 105.27 kB 105.31 kB
facebook-www/ReactDOM-prod.modern.js +0.03% 571.28 kB 571.44 kB +0.03% 101.21 kB 101.24 kB
facebook-www/ReactIs-dev.classic.js +3.33% 6.34 kB 6.55 kB +3.14% 1.37 kB 1.41 kB
facebook-www/ReactIs-dev.modern.js +3.33% 6.34 kB 6.55 kB +3.14% 1.37 kB 1.41 kB
facebook-www/ReactIs-prod.classic.js +2.89% 5.78 kB 5.94 kB +2.74% 1.35 kB 1.39 kB
facebook-www/ReactIs-prod.modern.js +2.89% 5.78 kB 5.94 kB +2.74% 1.35 kB 1.39 kB
test_utils/ReactAllWarnings.js Deleted 62.88 kB 0.00 kB Deleted 15.69 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-www/ReactIs-dev.classic.js +3.33% 6.34 kB 6.55 kB +3.14% 1.37 kB 1.41 kB
facebook-www/ReactIs-dev.modern.js +3.33% 6.34 kB 6.55 kB +3.14% 1.37 kB 1.41 kB
facebook-www/ReactIs-prod.classic.js +2.89% 5.78 kB 5.94 kB +2.74% 1.35 kB 1.39 kB
facebook-www/ReactIs-prod.modern.js +2.89% 5.78 kB 5.94 kB +2.74% 1.35 kB 1.39 kB
facebook-www/React-prod.modern.js +0.75% 22.27 kB 22.44 kB +0.62% 5.82 kB 5.85 kB
facebook-www/React-prod.classic.js +0.75% 22.27 kB 22.44 kB +0.62% 5.82 kB 5.86 kB
facebook-www/React-profiling.modern.js +0.74% 22.71 kB 22.87 kB +0.63% 5.90 kB 5.94 kB
facebook-www/React-profiling.classic.js +0.74% 22.71 kB 22.87 kB +0.61% 5.90 kB 5.94 kB
facebook-www/JSXDEVRuntime-dev.modern.js +0.61% 32.44 kB 32.64 kB +0.54% 7.59 kB 7.63 kB
facebook-www/JSXDEVRuntime-dev.classic.js +0.61% 32.57 kB 32.77 kB +0.54% 7.61 kB 7.65 kB
facebook-www/React-dev.modern.js +0.29% 72.82 kB 73.03 kB +0.28% 16.01 kB 16.06 kB
facebook-www/React-dev.classic.js +0.29% 73.68 kB 73.89 kB +0.38% 16.14 kB 16.21 kB
test_utils/ReactAllWarnings.js Deleted 62.88 kB 0.00 kB Deleted 15.69 kB 0.00 kB

Generated by 🚫 dangerJS against 284e05d

@jackpope jackpope merged commit 89580f2 into facebook:main Jun 24, 2024
@jackpope jackpope deleted the dynamic-rename-element-symbol branch June 24, 2024 16:28
github-actions bot pushed a commit that referenced this pull request Jun 24, 2024
@jackpope
Set renameElementSymbol to dynamic value (#30066)
893bdf0 
Prepare to roll this out with dynamic flag

`yarn flags --diff www canary`

<img width="514" alt="Screenshot 2024-06-24 at 11 33 55 AM"
src="https://github.com/facebook/react/assets/8965173/31508fdc-4cb1-4ce0-8e22-c02a034377b0">

DiffTrain build for [89580f2](89580f2)
@eps1lon eps1lon mentioned this pull request Jul 16, 2024
Closed
This was referenced Jul 25, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kassens kassens kassens approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jackpope @react-sizebot @kassens @facebook-github-bot