-
Notifications
You must be signed in to change notification settings - Fork 48.5k
UMD build doesn't work via import in the browser (TypeError: Cannot set property 'React' of undefined) #14635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
It's not expected that UMD imports would work with |
@gaearon I have looked into why the UMD build doesn't work, as I thought it should. (Of course an ESM build would be better, but in the meantime...) It is because rollup Is it feasible to upgrade the rollup dependency, or is there a reason to stick with that old version? |
I don't remember a particular reason. If you send a PR upgrading Rollup we can look at it! |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution. |
Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please create a new issue with up-to-date information. Thank you! |
When
import
ing the UMD build (both production and development) in the browser – that is, from a<script type="module">
– an error is thrown:TypeError: Cannot set property 'React' of undefined
.The relevant code:
Throws on line 15 as
global
≣this
isundefined
in a module context.Is this as simple to fix as passing
this || self
on line 16, or is there a catch?Do you want to request a feature or report a bug?
bug
What is the current behavior?
TypeError: Cannot set property 'React' of undefined
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem.
https://jsfiddle.net/dja3wfc7/ (Updated)
What is the expected behavior?
I would expect the
import
to work, as the same file works if included via<script src=...>
.Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?
React 16.7.0 (latest stable) – I have found another UMD related bug, #3037, which pertains to React 0.12.2. I have tried that version and indeed it works, it can be
import
ed.Chrome 71, Safari 12 tested (probably all browsers)
The text was updated successfully, but these errors were encountered: