You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi @bvaughn,
I really liked to check this issue, and I was able to create a PR to add highlighting for both FlameGraph and RankedList charts. (#17934 )
I've added the "good first issue (taken)" label so that others will know not to start work on the issue. If you change your mind about the issue, no worries! Just let me know so that I can remove the label and free it up for someone else to claim.
This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!
Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please create a new issue with up-to-date information. Thank you!
Hi @bvaughn, I took a look at @M-Izadmehr 's work on this and thought I'd offer to get it over the finish line. They haven't been active on GitHub for a while, so if you'd like assistance I'd be happy to fork and resolve the remaining conflicts and get it delivered. Apologies if that's bad etiquette!
I'm looking for ways to get my feet wet and start contributing here 🙂
Activity
M-Izadmehr commentedon Jan 30, 2020
Hi @bvaughn,
I really liked to check this issue, and I was able to create a PR to add highlighting for both FlameGraph and RankedList charts. (#17934 )
bvaughn commentedon Jan 30, 2020
This issue is all yours! 😄
I've added the "good first issue (taken)" label so that others will know not to start work on the issue. If you change your mind about the issue, no worries! Just let me know so that I can remove the label and free it up for someone else to claim.
Cheers!
stale commentedon Apr 29, 2020
This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!
stale commentedon May 6, 2020
Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please create a new issue with up-to-date information. Thank you!
steveadams commentedon May 6, 2020
Hi @bvaughn, I took a look at @M-Izadmehr 's work on this and thought I'd offer to get it over the finish line. They haven't been active on GitHub for a while, so if you'd like assistance I'd be happy to fork and resolve the remaining conflicts and get it delivered. Apologies if that's bad etiquette!
I'm looking for ways to get my feet wet and start contributing here 🙂
bvaughn commentedon May 6, 2020
Feel free to create an updated PR if you'd like, @steveadams.
steveadams commentedon May 6, 2020
Will do @bvaughn . Thanks for the speedy response!
bl00mber commentedon May 7, 2020
@bvaughn I've sent an updated PR