Skip to content

Profiler should highlight host components (e.g. DOM elements) on mouseover #17928

@bvaughn

Description

@bvaughn
Contributor

Feature request from a DevTools user at Faceook:

If I mouse over a node in the flame graph if you can highlight it in the view like the inspector that would be really amazing!

Activity

M-Izadmehr

M-Izadmehr commented on Jan 30, 2020

@M-Izadmehr
Contributor

Hi @bvaughn,
I really liked to check this issue, and I was able to create a PR to add highlighting for both FlameGraph and RankedList charts. (#17934 )

bvaughn

bvaughn commented on Jan 30, 2020

@bvaughn
ContributorAuthor

This issue is all yours! 😄

I've added the "good first issue (taken)" label so that others will know not to start work on the issue. If you change your mind about the issue, no worries! Just let me know so that I can remove the label and free it up for someone else to claim.

Cheers!

stale

stale commented on Apr 29, 2020

@stale

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

stale

stale commented on May 6, 2020

@stale

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please create a new issue with up-to-date information. Thank you!

reopened this on May 6, 2020
steveadams

steveadams commented on May 6, 2020

@steveadams

Hi @bvaughn, I took a look at @M-Izadmehr 's work on this and thought I'd offer to get it over the finish line. They haven't been active on GitHub for a while, so if you'd like assistance I'd be happy to fork and resolve the remaining conflicts and get it delivered. Apologies if that's bad etiquette!

I'm looking for ways to get my feet wet and start contributing here 🙂

bvaughn

bvaughn commented on May 6, 2020

@bvaughn
ContributorAuthor

Feel free to create an updated PR if you'd like, @steveadams.

steveadams

steveadams commented on May 6, 2020

@steveadams

Will do @bvaughn . Thanks for the speedy response!

bl00mber

bl00mber commented on May 7, 2020

@bl00mber
Contributor

@bvaughn I've sent an updated PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Participants

      @bvaughn@steveadams@bl00mber@M-Izadmehr

      Issue actions

        Profiler should highlight host components (e.g. DOM elements) on mouseover · Issue #17928 · facebook/react