Skip to content

DevTools: Hovering "Rendered by" list should highlight elements #18472

@gaearon

Description

@gaearon
Collaborator

This list is pretty awesome:

Screenshot 2020-04-03 at 00 12 08

But always struggle to guess which component in the owner list I need to jump to.

We should make hovering the owner list highlight components, just like the main tree view does.

@hristo-kanchev, interested?

Activity

hristo-kanchev

hristo-kanchev commented on Apr 3, 2020

@hristo-kanchev
Contributor

Sure, @gaearon.

I'll try and have something in place by the end of the week.

I'll keep you updated :)

hristo-kanchev

hristo-kanchev commented on Apr 3, 2020

@hristo-kanchev
Contributor

Something like this?

Light Theme:
OwnerButton-Hover

Dark Theme:
OwnerButton-Hover-Dark

hristo-kanchev

hristo-kanchev commented on Apr 3, 2020

@hristo-kanchev
Contributor

I've updated the PR and added the highlight native element feature.

👇

HighlightRenderedBy

gaearon

gaearon commented on Apr 3, 2020

@gaearon
CollaboratorAuthor

Amazing. This will help me a lot. Thank you so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @gaearon@hristo-kanchev

      Issue actions

        DevTools: Hovering "Rendered by" list should highlight elements · Issue #18472 · facebook/react