Skip to content

Bug: disableRemotePlayback not recognized #18618

@tomprats

Description

@tomprats

Passing disableRemotePlayback as an attribute like so:

<video disableRemotePlayback={true}>

Produces the warning:

Warning: React does not recognize the disableRemotePlayback prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase disableremoteplayback instead. If you accidentally passed it from a parent component, remove it from the DOM element.

It seems like React should recognize it's similar to #15334.

React version: 16.13.1

The current behavior

Warning and not rendering the attribute

The expected behavior

Adding the attribute similar to how it'd render disablePictureInPicture with a final output of:

<video disableRemotePlayback ...>

When rendering it with:

<video disableRemotePlayback={true} ...>

Activity

tombrowndev

tombrowndev commented on Apr 15, 2020

@tombrowndev
Contributor

Created a PR #18619

tombrowndev

tombrowndev commented on Apr 16, 2020

@tombrowndev
Contributor

@tomprats This has been merged in. Feel free to close the issue,

Cheers

tomprats

tomprats commented on Apr 16, 2020

@tomprats
Author

Thanks @tombrowndev, appreciate your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Status: UnconfirmedA potential issue that we haven't yet confirmed as a bug

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @tomprats@tombrowndev

        Issue actions

          Bug: disableRemotePlayback not recognized · Issue #18618 · facebook/react