-
Notifications
You must be signed in to change notification settings - Fork 49.2k
Closed
Labels
Status: UnconfirmedA potential issue that we haven't yet confirmed as a bugA potential issue that we haven't yet confirmed as a bug
Description
Passing disableRemotePlayback
as an attribute like so:
<video disableRemotePlayback={true}>
Produces the warning:
Warning: React does not recognize the
disableRemotePlayback
prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercasedisableremoteplayback
instead. If you accidentally passed it from a parent component, remove it from the DOM element.
It seems like React should recognize it's similar to #15334.
React version: 16.13.1
The current behavior
Warning and not rendering the attribute
The expected behavior
Adding the attribute similar to how it'd render disablePictureInPicture
with a final output of:
<video disableRemotePlayback ...>
When rendering it with:
<video disableRemotePlayback={true} ...>
kooku0 and siddharthkp
Metadata
Metadata
Assignees
Labels
Status: UnconfirmedA potential issue that we haven't yet confirmed as a bugA potential issue that we haven't yet confirmed as a bug
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
tombrowndev commentedon Apr 15, 2020
Created a PR #18619
tombrowndev commentedon Apr 16, 2020
@tomprats This has been merged in. Feel free to close the issue,
Cheers
tomprats commentedon Apr 16, 2020
Thanks @tombrowndev, appreciate your work!