Skip to content

Bug: Devtools' update-notifier usage is overly eager #20061

@NickHeiner

Description

@NickHeiner

When I run the devtools, I get the update-notifier message:

   ╭────────────────────────────────────────╮
   │                                        │
   │    Update available 4.4.0 → 4.9.0      │
   │   Run npm i react-devtools to update   │
   │                                        │
   ╰────────────────────────────────────────╯

I appreciate the goal of this message. However, the suggested command to run is incorrect for my repo. We use yarn, not npm. And we use a monorepo. This is confusing for devs who are new to the repo.

Would it be possible to suppress the update-notifier message? The team that manages usage of react-devtools in our tool chain is happy to stay on top of updates themselves.

Activity

bvaughn

bvaughn commented on Oct 20, 2020

@bvaughn
Contributor

This message is not something react-devtools logs. Pretty sure this is just something the npm command does to let you know that you aren't running the latest minor/bugfix version within your current major. I am wrong about this. Looks like we do intentionally notify of an update. I was unaware of that. 😆

Looks like this was added some time ago in facebook/react-devtools#695

Would you be interested in contributing a PR that uses the updateCheckInterval param to put a delay between these checks? Maybe once a week or something?

recurx

recurx commented on Oct 21, 2020

@recurx
Contributor

Hey @NickHeiner ! If you have not started, can I give it a try? Seems pretty straight-forward to add the check. Should we customise the message too (something more generic) ?

bvaughn

bvaughn commented on Oct 21, 2020

@bvaughn
Contributor

I don't think anyone has started on this, so please feel free @recurx.

recurx

recurx commented on Oct 21, 2020

@recurx
Contributor

Thanks @bvaughn . updateCheckInterval by default is 1 day. Changing this to 7 days. Should I also change the message to just this:
Screenshot 2020-10-21 at 7 31 09 PM

bvaughn

bvaughn commented on Oct 21, 2020

@bvaughn
Contributor

I think the message is fine. Any reason to change it?

recurx

recurx commented on Oct 21, 2020

@recurx
Contributor

Was just wondering about this sentence in the issue -

"However, the suggested command to run is incorrect for my repo. We use yarn, not npm. And we use a monorepo. This is confusing for devs who are new to the repo."

bvaughn

bvaughn commented on Oct 21, 2020

@bvaughn
Contributor

I see.

We could add update the wording to include yarn too I guess. Not sure we should try to cover all possible use cases (like monorepos). The main purpose of this message is to notify people that an update is available, but I think the added action of "run npm i react-devtools" is a nice prompt.

recurx

recurx commented on Oct 21, 2020

@recurx
Contributor

The 'how to install' is a nice prompt. But there would be many different ways people would be using react-devtools. For example if I'm using it globally, I'll have to add a -g, yarn users would need to do yarn add react-devtools . We can do something like this:
Screenshot 2020-10-21 at 8 20 57 PM
There might be more use-cases. Let me know what you think.

bvaughn

bvaughn commented on Oct 21, 2020

@bvaughn
Contributor

Like I said, I don't think we need to cover all use case 😄 It's nice to mention the most common case or two. That looks fine.

NickHeiner

NickHeiner commented on Oct 21, 2020

@NickHeiner
Author

Yes, @recurx, thanks for pointing out my concern about the message being incorrect. 😄 Changing the message interval doesn't really address the reason I opened this issue.

I agree that it's impractical to cover all use cases. And, frankly, for my users, it's not great to have a message that says something like "use yarn or use npm", because devs in my repo must use yarn.

The ideal solution from my end (and one that should be very easy to implement) is simply to provide an option to suppress showing this update notifier entirely. That option could default to false, and most people wouldn't need to know it existed.

gaearon

gaearon commented on Oct 21, 2020

@gaearon
Collaborator

it's not great to have a message that says something like "use yarn or use npm", because devs in my repo must use yarn.

Practically speaking, developers in your repo will encounter many libraries that say npm i something in their instructions. So they need to be aware anyway that npm i something should be substituted by yarn add something in general in your repo. I don't think this is a critical issue in this case.

1 remaining item

bvaughn

bvaughn commented on Oct 21, 2020

@bvaughn
Contributor

Changing the message interval doesn't really address the reason I opened this issue.

While it's not the outcome you're advocating for, I think it is still relevant to what prompted you to open the issue– since it reduces how frequently you'll see this (non-actionable) prompt.

If you would like to submit a PR that adds the ability to permanently opt out of this, you'd be welcome to. It doesn't look like that's something the library we're using provides support for though– and I suspect it's an uncommon enough want that not many people would be interested in doing the leg work but maybe I'm wrong.

NickHeiner

NickHeiner commented on Oct 21, 2020

@NickHeiner
Author

Yes, I agree that reducing the frequency reduces the impact of the issue. 😄

Perhaps I will submit that PR! Thanks for the invitation.

minshinkhant

minshinkhant commented on Oct 23, 2020

@minshinkhant

Hi, is this issue still opened?

shaiguelman

shaiguelman commented on Oct 23, 2020

@shaiguelman

Hi, if possible I would like to tackle this issue. Please let me know if it is still open. Thanks!

NickHeiner

NickHeiner commented on Oct 23, 2020

@NickHeiner
Author

I will hold off to give the other commenters a chance to work on this.

AmeyaPhadnis-2019H1030012G

AmeyaPhadnis-2019H1030012G commented on Oct 24, 2020

@AmeyaPhadnis-2019H1030012G

Hi, is this issue still open for contribution, I am new to the open-source community and looking forward to opportunities to contribute. Thanks in advance!

gabrielsanttana

gabrielsanttana commented on Nov 24, 2020

@gabrielsanttana

As @bvaughn said, it would be cool to mention the two most common cases, which in this case would be for npm and yarn.

abhishekdubey1

abhishekdubey1 commented on Nov 28, 2020

@abhishekdubey1

Hi, is this issue still open for contribution as I intend to work on this?

CobyCoding

CobyCoding commented on Dec 12, 2020

@CobyCoding

I believe this issue has been fixed.

rakesh456

rakesh456 commented on Dec 14, 2020

@rakesh456

Is this issue fixed?

mynameisankit

mynameisankit commented on Jan 23, 2021

@mynameisankit

Is the issue still unresolved or fixed? I would like to work on this

bvaughn

bvaughn commented on Jan 25, 2021

@bvaughn
Contributor

I'm going to close this issue because I think the current state of this feature is fine and I have no plans to change it. If someone would like to submit a PR+proposal for a new behavior though, I will review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @bvaughn@gaearon@NickHeiner@rakesh456@shaiguelman

        Issue actions

          Bug: Devtools' update-notifier usage is overly eager · Issue #20061 · facebook/react