Skip to content

Add support for <webview> chrome app node type #2108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jRiest opened this issue Aug 28, 2014 · 3 comments
Closed

Add support for <webview> chrome app node type #2108

jRiest opened this issue Aug 28, 2014 · 3 comments

Comments

@jRiest
Copy link

jRiest commented Aug 28, 2014

I'm using React in a Chrome App and it seems like it doesn't support the tag. I know this is a pretty specialized scenario so I don't know if it belongs in core, but is there some way I can manually add support for that tag, at least for a single project?

@syranide
Copy link
Contributor

You could easily create and attach it yourself during componentDidMount, it's obviously not the same thing, but I imagine that it will work just as well for you and you don't have to wait for another release for the fix (which might not happen "soon").

@jRiest
Copy link
Author

jRiest commented Aug 29, 2014

Sounds like a plan @syranide. I'll use the componentDidMount method for now. You're welcome to close this issue if you want, but I figured I'd leave it open in case you do choose to add <webview> as a supported tag in a future release.

@zpao
Copy link
Member

zpao commented Oct 29, 2014

Well, I said I wouldn't support it because it's not real html, so I guess I need to follow through. We no longer use the whitelist for dom components when going through React.createElement in 0.12 so if you wanted to use that directly you could and it might work (no guarantees). But we do still use the whitelist when transforming JSX, at least for now to provide a clean upgrade path to the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants