Skip to content

Renaming getComponentName to getComponentNameFromType in the error log #21446

@ohmyhusky

Description

@ohmyhusky

'Received an unexpected object in getComponentName(). ' +

A very small thing, would it be better to change the getComponentName to getComponentNameFromType in the error log since we separated the original logic into two functions (getComponentNameFromType, getComponentNameFromFiber)? Although it wouldn't be an issue for the authors, it feels like it would be better to sync it with the function name? Would you mind renaming it in the next 'typo fixing'?

Activity

bvaughn

bvaughn commented on May 7, 2021

@bvaughn
Contributor
ohmyhusky

ohmyhusky commented on May 7, 2021

@ohmyhusky
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @bvaughn@ohmyhusky

        Issue actions

          Renaming `getComponentName` to `getComponentNameFromType` in the error log · Issue #21446 · facebook/react