-
Notifications
You must be signed in to change notification settings - Fork 49.1k
Description
Website or app
proprietary
Repro steps
Overall, testing and refactoring of a component containing a formik wrapped form which includes a fieldarray with yup schema.
Using VS Code to serve the React js application.
Unable to share the repo / website as it is proprietary.
Task: Logged in to the app to see the form as the specific user role required to see the component, testing yup schema on formik elements touched property to do some custom error connections in the containing component with React Developer Tools open to the Components view with the console also open.
I was verifying the elements described in the schema file were getting 'touched' and was refining a select in yup schema js file.
Switched one element's schema property from yup.object() to yup.int() triggers the error. This is a syntax error. Should be yup.number(). But switching the two causes it all to crash.
"formik": "^2.2.6",
"prop-types": "^15.7.2",
"react": "^17.0.2",
"react-router-dom": "4.3.1",
"react-select": "^4.3.0",
"yup": "^0.26.10"
"yarn": "^1.13.0",
"babel-eslint": "^10.1.0",
How often does this bug happen?
Every time
DevTools package (automated)
react-devtools-extensions
DevTools version (automated)
4.23.0-e28a0db22
Error message (automated)
Cannot remove node "612" because no matching node was found in the Store.
Error call stack (automated)
at chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:26349:43
at bridge_Bridge.emit (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:24415:22)
at chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:24581:14
at listener (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:54033:39)
Error component stack (automated)
No response
GitHub query string (automated)
https://github.com/api/search/issues?q=Cannot remove node because no matching node was found in the Store. in:title is:issue is:open is:public label:"Component: Developer Tools" repo:facebook/react
Activity
bvaughn commentedon Jan 28, 2022
Unfortunately "proprietary" isn't a repro we can do anything with. Handing this back to you in hopes of getting something we can repro and look into, @steve-snow.
Generally it's helpful to reduce the problem locally to as little code as you can (including dependencies) and then host it on Code Sandbox.
RobIsHere commentedon Jan 30, 2022
I can confirm that I have the same issue.
RobIsHere commentedon Jan 30, 2022
It also happens when I fill in a form field. As soon as this happens, parameters given to my component change and this bug immediately appears every time.
lunaruan commentedon Jan 31, 2022
@RobIsHere Thanks for commenting! Unfortunately, without a reproducible repro on our side, we're unable to debug this issue. Could you create a repro of this on Code Sandbox? Thanks!
steve-snow commentedon Jan 31, 2022
lunaruan commentedon Feb 1, 2022
Thanks so much! That would be a huge help 😊
ariccio commentedon Feb 10, 2022
I've been seeing this a lot myself lately! It looks like others have been seeing variations of it too:
#21527
#21529
#21534
#21563
#21568
#21636
#21653
#21755 (FYI I'm running
4.23.0
)#21764
#22611
For a bug like this, maybe we need some better diagnostics? I can't identify any individual change in my code that made this happen.
steve-snow commentedon Feb 12, 2022
This is going to take a bit more work to find the culprit.
Starting with the basic react app and adding yup and formik did not cause the fatal crash with the syntax error trigger. You will see the same yup error. So I'll be iterating through the package.json differences until I get something that blows it up. For now, this is the starting point. But it is not the fatal error I was hoping to find.
Specifically, the syntax trigger was to change the following in the schema file:
age: Yup.number()
to
age: Yup.int()
https://github.com/steve-snow/react-validation-glitch-testing.git
gibin-george-supersourcing commentedon Mar 12, 2022
The error was thrown at chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:26448:43
at bridge_Bridge.emit (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:24400:22)
at chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:24566:14
at listener (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:54300:39)
kux888 commentedon Mar 17, 2022
Everything was normal until today
6 remaining items
evangrim commentedon Mar 23, 2022
I got this error using react-devtools 4.24.1.
Reinstalling npm install react-devtools@4.2 solved my issue. (Also possible a fresh install helped.)
Also FWIW with 4.24.1, I had an issue where react-devtools loaded and seemed to connect but no components displayed (filters were removed).
moisesrj97 commentedon Apr 18, 2022
I am having the same issue when trying to switch the component rendered inside a Suspense.
react-devtools version: 4.24.3-46a98cff2
Demo: https://codesandbox.io/s/amazing-blackburn-k2iql8?file=/src/App.js
shamilovtim commentedon Apr 19, 2022
Edit: see follow up below
shamilovtim commentedon Apr 20, 2022
UPDATE: See comment below for full fix and information.
Hello @lunaruan @bvaughn sorry for the tag but I thought I'd comment that I've isolated this issue to a specific DevTools release where it got introduced: between ~~4.13.0...4.13.1~~~ 4.7.0 and 4.8.0 (UPDATE: See comment below,) I'll list our stack and see attached screengrabs for evidence.
ENV INFO:
node
isv14.17.3
installed with nvm at/Users/admin/.nvm/versions/node/v14.17.3/bin/node
npm 8.5.5
installed at/Users/admin/.nvm/versions/node/v14.17.3/bin/npm
react: 17.0.2
react-native: 0.65.2
which depends transitively onreact-dev-tools-core@^4.6.0
and resolved at"4.13.5"
react-dev-tools
: installed withyarn global add react-devtools@4.7.0
at/usr/local/bin/react-devtools
, which incrementing to4.8.0
will consistently reproduce errorsRegarding what I've tried. I've tried unlocking the local transitive to latest (4.24.4 or whatever) and installing global 4.24.4. This reproduces the node 161 error message. I've tried almost every version over 4.7.0 and all of them throw errors. I've tried installing those latest versions with
npm -g
instead of yarn and it didn't help. I've tried using latest react-devtools with node v16 as well as node v13, with react-devtools installed globally inside of each of those particular node versions and that didn't help either.My conclusion is that despite react-native
0.65.2
specifying a transitive^4.6.0
the reality is that it only supports4.7.0
and lower. Given that this is an older version of RN, I doubt that they're going to make a patch release to fix this. So perhaps the ball is in the DevTools team's court to make react devtools > 4.7.0 backwards compatible?Thanks for reading!
bvaughn commentedon Apr 20, 2022
Thanks for the follow up info. I suspect 4.13.1 is maybe a bad lead though, in terms of when the bug was "introduced" – because that version included #21426 (which basically made DevTools stop silently swallowing certain types of Store errors). In other words, 4.13.0 (and older) were probably also broken but in a less obvious way.
shamilovtim commentedon Apr 20, 2022
You're right @bvaughn it was just swallowing the error and neither the profiler tab nor the component tab were working. I've now isolated to no errors whatsoever. I did it by locking react native's transitive
react-devtools-core
to4.7.0
(rather than ^4.6.0) and installed global devtools withyarn global add react-devtools@4.7.0.
The break happens betweenreact-devtools
4.7.0...4.8.0. I suspect React Native has not locked to the correct transitive version, which is why you guys can't reproduce this. They just need to remove the^
from their transitive dependency on react-devtools-core in package.json. For backwards compat the fix is probably between those two versions. I'll update my previous comment to point here.4.7.0 success, both components and profiler working:

bvaughn commentedon Apr 20, 2022
Interesting! Nice sleuthing.
Things broke in version 4.8? 😮 That release was very small:
https://github.com/facebook/react/blob/main/packages/react-devtools/CHANGELOG.md#480
lunaruan commentedon May 5, 2022
@shamilovtim Wow nice find! I tried reproducing with my local React Native app on v4.8, but I couldn't reproduce the bug. Do you have a link to your app that I can take a look at to see if I can repro on my side?
shamilovtim commentedon May 5, 2022
Ah sorry @lunaruan but Shipt is closed source. I wonder, did you test on the react native version that was experiencing this problem? We're on 0.65.x. I assume this isn't worth hotfixing, you can probably just have this ticket serve as the solution for people still on older versions.
kofkgoing commentedon Oct 13, 2022
facebook/flipper#3649