-
Notifications
You must be signed in to change notification settings - Fork 48.6k
Document React.addons.batchedUpdates #3570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
rAF batching isn't supported and won't go in the docs, but batchedUpdates should. |
is rAF batching discouraged, or just not suitable for shipping with core? Would it be reasonable to link to an up-to-date npm project on the batchedUpdates page? |
We don't use it at Facebook and it's not clear that it solves real problems, so we don't want to maintain it or have to fix bugs related to it. React.addons.batchedUpdates should give enough control over batching. |
There are also known issues with rAF batching (mostly around controlled components). |
Should we deprecate and eventually remove the RAF batching? |
It's never been supported in any fashion. |
(i.e., it's already deprecated?) |
shouldn't this file be deleted in that case? |
That's not exposed as a public API in any of our builds, but sure, we can delete it – PR incoming. |
We don't use or support this, so let's just delete it. (facebook#3570)
Killed in #6016 |
We should document ReactDOM.unstable_batchedUpdates. |
@spicyj Since when did we start documenting It was a different situation when it was an addon, the issue made sense at that time. |
Sure. |
I didn't realise this was in the addons bundle, would be good to get it added to the docs.
http://facebook.github.io/react/docs/addons.html
https://github.com/facebook/react/blob/master/src/browser/ReactWithAddons.js#L40
Would be good to also include an example of using https://github.com/facebook/react/blob/master/src/addons/ReactRAFBatchingStrategy.js or something similar.
The text was updated successfully, but these errors were encountered: