Need a test for setState in shallow render

[glenjamin]

Related to #2393

Rendering a component like this:

<div onClick={() => this.setState({something: 1}) />

rendering via shallow render, then calling handler

var result = shallowRenderer.getRenderOutput();
result.props.onClick()

Produces the following:

    ReferenceError: document is not defined
      at getActiveElement (myapp/node_modules/react/lib/getActiveElement.js:23:12)
      at ReactReconcileTransaction.ReactInputSelection.getSelectionInformation (myapp/node_modules/react/lib/ReactInputSelection.js:40:23)
      at ReactReconcileTransaction.Mixin.initializeAll (myapp/node_modules/react/lib/Transaction.js:168:30)
      at ReactReconcileTransaction.Mixin.perform (myapp/node_modules/react/lib/Transaction.js:133:12)
      at ReactUpdatesFlushTransaction.Mixin.perform (myapp/node_modules/react/lib/Transaction.js:134:20)
      at ReactUpdatesFlushTransaction.assign.perform (myapp/node_modules/react/lib/ReactUpdates.js:95:38)
      at Object.flushBatchedUpdates (myapp/node_modules/react/lib/ReactUpdates.js:175:19)
      at Object.wrapper [as flushBatchedUpdates] (myapp/node_modules/react/lib/ReactPerf.js:70:21)
      at ReactDefaultBatchingStrategyTransaction.Mixin.closeAll (myapp/node_modules/react/lib/Transaction.js:207:25)
      at ReactDefaultBatchingStrategyTransaction.Mixin.perform (myapp/node_modules/react/lib/Transaction.js:148:16)
      at Object.ReactDefaultBatchingStrategy.batchedUpdates (myapp/node_modules/react/lib/ReactDefaultBatchingStrategy.js:66:19)
      at Object.enqueueUpdate (myapp/node_modules/react/lib/ReactUpdates.js:215:22)
      at enqueueUpdate (myapp/node_modules/react/lib/ReactUpdateQueue.js:30:18)
      at Object.ReactUpdateQueue.enqueueSetState (myapp/node_modules/react/lib/ReactUpdateQueue.js:208:5)
      at [object Object].ReactComponent.setState (myapp/node_modules/react/lib/ReactComponent.js:69:20)
      at Object.React.createElement.React.createElement.React.createElement.onChange (myapp/client/components/LoginForm.js:30:35)

Ideally, this module should realise it's running on the server, and skip this behaviour check

[jimfb]

cc @graue

[gaearon]

I think I don't have this problem in 0.14, can somebody else verify?

[sophiebits]

40b7c19 may have fixed this. Not sure it actually rerenders though?

[glenjamin]

Just tried this on 0.14.0-beta3 - reproduces in the same way as 0.13.

> node -e 'console.log(process.versions)'
{ http_parser: '2.3',
  node: '0.12.7',
  v8: '3.28.71.19',
  uv: '1.6.1',
  zlib: '1.2.8',
  modules: '14',
  openssl: '1.0.1p' }

var React = require('react');
var TestUtils;
if (React.version.substring(4) == '0.13') {
  TestUtils = require('react/addons').addons.TestUtils;
} else {
  TestUtils = require('react-addons-test-utils');
}

if (process.env.document) {
  global.document = {};
}

var renderer = TestUtils.createRenderer();

var Node = React.createClass({
  getInitialState: function() {
    return { foo: 'bar' };
  },
  clicked: function() {
    this.setState({foo: 'baz'});
  },
  render: function() {
    return (
      React.createElement('div', {
        onClick: this.clicked
      }, this.state.foo)
    );
  }
});

renderer.render(
  React.createElement(Node)
);

renderer.getRenderOutput().props.onClick();

console.log(renderer.getRenderOutput().props.children);

0.13

> node sample.js
/myapp/node_modules/react/lib/getActiveElement.js:23
    return document.body;
           ^
ReferenceError: document is not defined
    at getActiveElement (/myapp/node_modules/react/lib/getActiveElement.js:23:12)
    at ReactReconcileTransaction.ReactInputSelection.getSelectionInformation (/myapp/node_modules/react/lib/ReactInputSelection.js:40:23)
    at ReactReconcileTransaction.Mixin.initializeAll (/myapp/node_modules/react/lib/Transaction.js:168:30)
    at ReactReconcileTransaction.Mixin.perform (/myapp/node_modules/react/lib/Transaction.js:133:12)
    at ReactUpdatesFlushTransaction.Mixin.perform (/myapp/node_modules/react/lib/Transaction.js:134:20)
    at ReactUpdatesFlushTransaction.assign.perform (/myapp/node_modules/react/lib/ReactUpdates.js:95:38)
    at Object.flushBatchedUpdates (/myapp/node_modules/react/lib/ReactUpdates.js:175:19)
    at Object.wrapper [as flushBatchedUpdates] (/myapp/node_modules/react/lib/ReactPerf.js:70:21)
    at ReactDefaultBatchingStrategyTransaction.Mixin.closeAll (/myapp/node_modules/react/lib/Transaction.js:207:25)
    at ReactDefaultBatchingStrategyTransaction.Mixin.perform (/myapp/node_modules/react/lib/Transaction.js:148:16)

0.13 with document hack

> document=1 node sample.js
baz

0.14.0-beta4

> node sample.js
/myapp/node_modules/react/node_modules/fbjs/lib/getActiveElement.js:25
    return document.body;
           ^
ReferenceError: document is not defined
    at getActiveElement (/myapp/node_modules/react/node_modules/fbjs/lib/getActiveElement.js:25:12)
    at ReactReconcileTransaction.ReactInputSelection.getSelectionInformation (/myapp/node_modules/react/lib/ReactInputSelection.js:38:23)
    at ReactReconcileTransaction.Mixin.initializeAll (/myapp/node_modules/react/lib/Transaction.js:168:75)
    at ReactReconcileTransaction.Mixin.perform (/myapp/node_modules/react/lib/Transaction.js:135:12)
    at ReactUpdatesFlushTransaction.Mixin.perform (/myapp/node_modules/react/lib/Transaction.js:136:20)
    at ReactUpdatesFlushTransaction.assign.perform (/myapp/node_modules/react/lib/ReactUpdates.js:86:38)
    at Object.flushBatchedUpdates (/myapp/node_modules/react/lib/ReactUpdates.js:147:19)
    at Object.wrapper [as flushBatchedUpdates] (/myapp/node_modules/react/lib/ReactPerf.js:66:21)
    at ReactDefaultBatchingStrategyTransaction.Mixin.closeAll (/myapp/node_modules/react/lib/Transaction.js:202:25)
    at ReactDefaultBatchingStrategyTransaction.Mixin.perform (/myapp/node_modules/react/lib/Transaction.js:149:16)

0.14.0-beta3 with document hack

> document=1 node sample.js
baz

There's no git tags for the 0.14 series, but from a grep around it looks like that commit is present in beta3.

[sebmarkbage]

@spicyj Should we have a custom transaction for shallow rendering? (Eventually we should get rid of transactions completely.)