Check that container is a valid DOM element
#112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like the right thing to do! 👍 |
| var container = document.createElement('div'); | ||
| // jQuery objects are basically arrays; people often pass them in by mistake | ||
| expect(function() { | ||
| ReactMount.renderComponent(<div></div>, [container]); |
There was a problem hiding this comment.
Nit: Not actually important, but we usually write our empty elements as <div/>. Can you update to do that? I'm pulling this in and getting it reviewed now, but that's my only comment.
zpao
added a commit
that referenced
this pull request
Jun 25, 2013
Check that `container` is a valid DOM element
This was referenced Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had another one of my friends get confused by this today.