Remove global mocks by adding a global flag #11632
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are making it harder to test compiled bundles. One of them (FeatureFlags) is not used. It is mocked in some specific test files (and that's fine). The other (FiberErrorLogger) is mocked to silence its output. I'll look if there's some other way to achieve this.
It is intended to be used in tests in cases when you intentionally throw errors and don't want to repeat the same assertions about warnings. We don't promise to support it indefinitely.
bvaughn
approved these changes
Nov 22, 2017
| __REACT_UNSTABLE_SUPPRESS_ERROR_LOGGING__ === true | ||
| ) { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
🙃
return (
typeof __REACT_UNSTABLE_SUPPRESS_ERROR_LOGGING__ === 'undefined' ||
__REACT_UNSTABLE_SUPPRESS_ERROR_LOGGING__ !== true
);Edit for clarity: This is just a nit. It seems like you could combine the if-condition-return into just a return.
|
I mean... I could also look into some magic to suppress these warnings at the test site. For example by adding Adding this magic will probably make tests more confusing if we ever want to change logging behavior. But the upside is all the hacks are isolated to our tests, and won't affect Prepack etc. |
gaearon
changed the title
|
I like this more: #11636 |
|
Went with #11636 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary for running a subset of tests against flat bundles.
I added a global unstable flag to avoid exposing yet another injection for error reporting.
Not ideal, but it works and can serve as an escape hatch to #11098.