Skip to content

Don't reset error codes on CI build #11655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 25, 2017
Merged

Don't reset error codes on CI build #11655

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6be76d
Don't reset error codes on CI build
gaearon Nov 25, 2017
c08481d
Add an explanation
gaearon Nov 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion scripts/circleci/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@
set -e

yarn build --extract-errors
git checkout -- scripts/error-codes/codes.json
# Note: since we run the full build including extracting error codes,
# it is important that we *don't* reset the change to `scripts/error-codes/codes.json`.
# When production bundle tests run later, it needs to be available.
# See https://github.com/facebook/react/pull/11655.

# Do a sanity check on bundles
node ./scripts/rollup/validate/index
Expand Down