Batch updates caused by handlers in multiple roots #1231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm assuming but want to confirm - this fixes the layers bug we were talking about on Thursday? |
|
No, it doesn't. Still a good idea though. |
| var parentControl = <div>Parent</div>; | ||
| ReactMount.renderComponent(childControl, childContainer); | ||
| ReactMount.renderComponent(parentControl, parentContainer); | ||
| parentControl.getDOMNode().appendChild(childContainer); |
There was a problem hiding this comment.
Can you rebase and update for descriptors. This isn't going to be the right thing anymore.
Fixes facebook#1227. It seems rare that event handlers in two roots nested in the DOM will update the same component in the same tick, but if that happens, the updates should be batched together.
zpao
added a commit
that referenced
this pull request
Apr 12, 2014
Batch updates caused by handlers in multiple roots
This was referenced Sep 16, 2021
This was referenced Nov 5, 2022
This was referenced Dec 25, 2022
This was referenced Nov 27, 2023
This was referenced May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1227.
It seems rare that event handlers in two roots nested in the DOM will update the same component in the same tick, but if that happens, the updates should be batched together.