Add interaction-tracking/subscriptions #13426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 17, 2018 10:52
bvaughn
changed the title
sebmarkbage
reviewed
Aug 17, 2018
| } | ||
|
|
||
| export function subscribe(subscriber: Subscriber): void { | ||
| subscribers.add(subscriber); |
There was a problem hiding this comment.
Shouldn't these be noops if enableInteractionTracking is false?
| } | ||
| } | ||
|
|
||
| __subscriberRef.current = { |
There was a problem hiding this comment.
This shouldn't bother subscribing if enableInteractionTracking is false, right?
acdlite
reviewed
Aug 17, 2018
| wrappedInteractions.forEach(interaction => { | ||
| interaction.__count--; | ||
| try { | ||
| returnValue = callback.apply(undefined, arguments); |
There was a problem hiding this comment.
Just noticed this... wrapped is an arrow function here, so these are the arguments to the outer function. Need a test.
Details of bundled changes.Comparing: 5e0f073...f1a3d3c interaction-tracking
Generated by 🚫 dangerJS |
5 tasks
acdlite
reviewed
Aug 17, 2018
| @@ -195,7 +195,7 @@ export function wrap( | |||
| interaction.__count++; | |||
| }); | |||
|
|
|||
| const wrapped = () => { | |||
| const wrapped = (...args) => { | |||
There was a problem hiding this comment.
You could also change this to a normal function :D
There was a problem hiding this comment.
It's a nit. I'm just paranoid about the Babel output.
There was a problem hiding this comment.
The Babel output is fine. I've checked it. 😄
But sure, I don't mind.
sebmarkbage
approved these changes
Aug 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to PR #13234
enableInteractionTrackingandenableInteractionTrackingObserverfeature flagsinteraction-tracking/subscriptionsbundle