-
Notifications
You must be signed in to change notification settings - Fork 49.6k
Fix a crash in Suspense with findDOMNode #15195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,6 +21,8 @@ import { | |
HostRoot, | ||
HostPortal, | ||
HostText, | ||
Fragment, | ||
SuspenseComponent, | ||
} from 'shared/ReactWorkTags'; | ||
import {NoEffect, Placement} from 'shared/ReactSideEffectTags'; | ||
|
||
|
@@ -119,8 +121,27 @@ export function findCurrentFiberUsingSlowPath(fiber: Fiber): Fiber | null { | |
let parentA = a.return; | ||
let parentB = parentA ? parentA.alternate : null; | ||
if (!parentA || !parentB) { | ||
// We're at the root. | ||
break; | ||
// We're either at the root, or we're in a special Fragment | ||
// with no alternate, which is how Suspense (un)hiding works. | ||
let maybeSuspenseFragment = parentA || parentB; | ||
if (maybeSuspenseFragment && maybeSuspenseFragment.tag === Fragment) { | ||
const maybeSuspense = maybeSuspenseFragment.return; | ||
if ( | ||
maybeSuspense && | ||
maybeSuspense.tag === SuspenseComponent && | ||
// If state isn't null, it timed out and we have two Fragment children. | ||
maybeSuspense.memoizedState !== null | ||
) { | ||
parentA = maybeSuspense; | ||
parentB = maybeSuspense; | ||
a = maybeSuspenseFragment; | ||
b = maybeSuspenseFragment; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't know if it's legit to have them pointing to the same one. I haven't really thought whether this makes sense. |
||
} else { | ||
break; | ||
} | ||
} else { | ||
break; | ||
} | ||
} | ||
|
||
// If both copies of the parent fiber point to the same child, we can | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it’s possible for the suspense to have an alternate and we might be coming from the disconnected tree.