React events: fix nested Hover components error #15428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trueadm
approved these changes
Apr 16, 2019
necolas
force-pushed
the
react-events/fix-hover
branch
from
652d7dd to
80bfb11
Compare
|
Updated the patch to remove the addition of support for stopPropagation (no functional difference to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a test that reproduces the error and unexpected output. The error was being caused by the
hoverTargetbeing set tonulleven if the module bailed out of dispatching the hover end events.How to achieving the desired results for nested Hover will require further consideration.
Ref #15257