Skip to content

[react-native] Rewrite Haste imports in RN shims and add .fb.js extension #15786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/shared/forks/ReactFeatureFlags.native-fb.js
Original file line number Diff line number Diff line change
@@ -13,7 +13,9 @@ import typeof * as FeatureFlagsType from 'shared/ReactFeatureFlags';
import typeof * as FeatureFlagsShimType from './ReactFeatureFlags.native-fb';

// Re-export dynamic flags from the fbsource version.
export const {debugRenderPhaseSideEffects} = require('ReactFeatureFlags');
export const {
debugRenderPhaseSideEffects,
} = require('../shims/ReactFeatureFlags');

// The rest of the flags are static for better dead code elimination.
export const enableUserTimingAPI = __DEV__;
5 changes: 5 additions & 0 deletions scripts/flow/react-native-host-hooks.js
Original file line number Diff line number Diff line change
@@ -157,3 +157,8 @@ declare module 'RTManager' {

declare function completeUpdates(): void;
}

// shims/ReactFeatureFlags is generated by the packaging script
declare module '../shims/ReactFeatureFlags' {
declare export var debugRenderPhaseSideEffects: boolean;
}
10 changes: 7 additions & 3 deletions scripts/rollup/packaging.js
Original file line number Diff line number Diff line change
@@ -56,7 +56,7 @@ function getBundleOutputPaths(bundleType, filename, packageName) {
case RN_OSS_PROFILING:
switch (packageName) {
case 'react-native-renderer':
return [`build/react-native/oss/${filename}`];
return [`build/react-native/implementations/${filename}`];
default:
throw new Error('Unknown RN package.');
}
@@ -65,7 +65,12 @@ function getBundleOutputPaths(bundleType, filename, packageName) {
case RN_FB_PROFILING:
switch (packageName) {
case 'react-native-renderer':
return [`build/react-native/fb/${filename}`];
return [
`build/react-native/implementations/${filename.replace(
/\.js$/,
'.fb.js'
)}`,
];
default:
throw new Error('Unknown RN package.');
}
@@ -93,7 +98,6 @@ async function copyRNShims() {
require.resolve('react-native-renderer/src/ReactNativeTypes.js'),
'build/react-native/shims/ReactNativeTypes.js'
),
asyncCopyTo(`${__dirname}/shims/react-native-fb`, 'build/react-native/fb'),
]);
}

4 changes: 2 additions & 2 deletions scripts/rollup/shims/react-native/NativeMethodsMixin.js
Original file line number Diff line number Diff line change
@@ -12,9 +12,9 @@

const {
__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED,
} = require('ReactNative');
} = require('./ReactNative');

import type {NativeMethodsMixinType} from 'ReactNativeTypes';
import type {NativeMethodsMixinType} from './ReactNativeTypes';

const {NativeMethodsMixin} = __SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED;

8 changes: 4 additions & 4 deletions scripts/rollup/shims/react-native/ReactFabric.js
Original file line number Diff line number Diff line change
@@ -10,17 +10,17 @@

'use strict';

const BatchedBridge = require('BatchedBridge');
import {BatchedBridge} from 'react-native/Libraries/ReactPrivate/ReactNativePrivateInterface';

// TODO @sema: Adjust types
import type {ReactNativeType} from 'ReactNativeTypes';
import type {ReactNativeType} from './ReactNativeTypes';

let ReactFabric;

if (__DEV__) {
ReactFabric = require('ReactFabric-dev');
ReactFabric = require('../implementations/ReactFabric-dev');
} else {
ReactFabric = require('ReactFabric-prod');
ReactFabric = require('../implementations/ReactFabric-prod');
}

BatchedBridge.registerCallableModule('ReactFabric', ReactFabric);
6 changes: 3 additions & 3 deletions scripts/rollup/shims/react-native/ReactNative.js
Original file line number Diff line number Diff line change
@@ -10,14 +10,14 @@

'use strict';

import type {ReactNativeType} from 'ReactNativeTypes';
import type {ReactNativeType} from './ReactNativeTypes';

let ReactNative;

if (__DEV__) {
ReactNative = require('ReactNativeRenderer-dev');
ReactNative = require('../implementations/ReactNativeRenderer-dev');
} else {
ReactNative = require('ReactNativeRenderer-prod');
ReactNative = require('../implementations/ReactNativeRenderer-prod');
}

module.exports = (ReactNative: ReactNativeType);
Original file line number Diff line number Diff line change
@@ -10,9 +10,11 @@

'use strict';

import {ReactNativeViewConfigRegistry} from 'react-native/Libraries/ReactPrivate/ReactNativePrivateInterface';

import type {ViewConfigGetter} from './ReactNativeTypes';

const {register} = require('ReactNativeViewConfigRegistry');
const {register} = ReactNativeViewConfigRegistry;

/**
* Creates a renderable ReactNative host component.
6 changes: 1 addition & 5 deletions scripts/rollup/validate/index.js
Original file line number Diff line number Diff line change
@@ -60,11 +60,7 @@ const bundles = [
},
{
format: 'rn',
filePatterns: [
`./build/react-native/oss/*.js`,
`./build/react-native/fb/ReactFabric-*.js`,
`./build/react-native/fb/ReactNativeRenderer-*.js`,
],
filePatterns: [`./build/react-native/implementations/*.js`],
},
{
format: 'umd',