Example Bootstrap modal closing bug fix. #160
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ugh, accidentally tweaked stuff and screwed up the pull, will close this and submit a new one, sorry. |
bvaughn
pushed a commit
to bvaughn/react
that referenced
this pull request
Aug 13, 2019
Add production mode to dev shell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old version's modal doesn't close correctly, because it gets re-rendered (following a parent's state variable change) before having the change to play the closing animation. This fixes it, but more or less defeats the purpose of showing a toggling state in parent. Will open new issue to discuss about this.