Skip to content

add 'cache: false,' to tutorial #1623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

brigand
Copy link
Contributor

@brigand brigand commented May 29, 2014

@ToucheSir
Copy link

Wouldn't it be simpler to disable caching in Firefox's devtools? Setting cache: false might give people the wrong idea regarding using asynchronous requests with React.

@brigand
Copy link
Contributor Author

brigand commented May 30, 2014

@ToucheSir it's probably simpler to sneak it into the code than to ask/expect people to do something special in their browser. It already tripped one person up, which usually means at least 4 or 5 others had the same problem and didn't report it.

@zpao
Copy link
Member

zpao commented Jun 16, 2014

Let's add an inline comment about why we're using cache: false to help educate the copy+pasters.

@sophiebits
Copy link
Collaborator

Also note that this appears 5 times in the tutorial and the line highlights are messed up by adding a line.

@zpao
Copy link
Member

zpao commented Jul 3, 2014

@brigand, are you still interested in doing this?

@brigand
Copy link
Contributor Author

brigand commented Jul 7, 2014

@zpao doing what? I personally don't think an explanation is needed; it'd just distract from the point of the tutorial.

Sorry for the late response.

@zpao
Copy link
Member

zpao commented Jul 7, 2014

I'm asking if you're interested in following through with this PR - there are unresolved issues in the comments from me and @spicyj. I still think we should add a short comment on the first use.

@brigand
Copy link
Contributor Author

brigand commented Jul 7, 2014

I added the inline comment,

cache: false, // needed for SimpleHTTPServer

and put the other cache: false lines in.

@zpao
Copy link
Member

zpao commented Jul 30, 2014

Last couple weeks have been busy, I apologize for the really sporadic pings here :/

Can we get the line highlights fixed like @spicyj mentioned above? We use a syntax for codeblocks which results in specific lines being highlighted and just inserting new lines without adjusting offsets results in bad highlighting.

If you're not up for it, I understand, just let me know!

Before:
screen shot 2014-07-30 at 10 33 17 am
After:
screen shot 2014-07-30 at 10 33 29 am

@zpao
Copy link
Member

zpao commented Jan 17, 2015

With using real servers now in https://github.com/reactjs/react-tutorial, I think we can just skip this.

@zpao zpao closed this Jan 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants