-
Notifications
You must be signed in to change notification settings - Fork 48.6k
add 'cache: false,' to tutorial #1623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Wouldn't it be simpler to disable caching in Firefox's devtools? Setting |
@ToucheSir it's probably simpler to sneak it into the code than to ask/expect people to do something special in their browser. It already tripped one person up, which usually means at least 4 or 5 others had the same problem and didn't report it. |
Let's add an inline comment about why we're using |
Also note that this appears 5 times in the tutorial and the line highlights are messed up by adding a line. |
@brigand, are you still interested in doing this? |
@zpao doing what? I personally don't think an explanation is needed; it'd just distract from the point of the tutorial. Sorry for the late response. |
I'm asking if you're interested in following through with this PR - there are unresolved issues in the comments from me and @spicyj. I still think we should add a short comment on the first use. |
I added the inline comment, cache: false, // needed for SimpleHTTPServer and put the other cache: false lines in. |
Last couple weeks have been busy, I apologize for the really sporadic pings here :/ Can we get the line highlights fixed like @spicyj mentioned above? We use a syntax for codeblocks which results in specific lines being highlighted and just inserting new lines without adjusting offsets results in bad highlighting. If you're not up for it, I understand, just let me know! |
With using real servers now in https://github.com/reactjs/react-tutorial, I think we can just skip this. |
Re: React tutorial - ajax cache headsup (Google Groups).