Failing test: DevTools hook freezes timeline #17159
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DevTools hook calls `requestCurrentTime` after the commit phase has ended, which has the accidnental consequence of freezing the start time for subsequent updates. If enough time goes by, the next update will instantly expire. I'll push a fix in the next commit.
acdlite
force-pushed
the
devtools-freeze-timeline
branch
from
4e4f465 to
68aa840
Compare
sebmarkbage
approved these changes
Oct 21, 2019
|
Merged as part of #17160 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DevTools hook calls
requestCurrentTimeafter the commit phase has ended, which has the accidental consequence of freezing the start time for subsequent updates. If enough time goes by, the next update will instantly expire.I'll open potential fixes in separate PRs:
requestCurrentTimeafter commit phase has ended: Read current time without marking event start time #17160