[SuspenseList] Don't treat the last row in hidden as deleted if already mounted #17206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebmarkbage
changed the title
|
For the purposes of using the "tail" option you probably don't really ever care about already mounted components being part of the tail and we could just consider all of them as part of the head. However, when you don't use it an update causes a resuspend it might be a bit confusing that they're now in "together" mode (since the head is always in "together" mode). It would simplify things a bit if we just dropped this for updates though. |
bvaughn
approved these changes
Oct 29, 2019
| @@ -2135,4 +2135,159 @@ describe('ReactSuspenseList', () => { | |||
| </div>, | |||
| ); | |||
| }); | |||
|
|
|||
| it('eventually resolves two nested forwards suspense list with a hidden tail', async () => { | |||
There was a problem hiding this comment.
nit: "forwards suspense lists"
There was a problem hiding this comment.
oops. this is a copy paste of the test above.
Already mounted rows that resuspend may be considered as part of a tail if they're at the end. However, for purposes of the tail="..." option they don't get deleted. We deal with that in cutOffTailIfNeeded. However, if they're also the first to suspend in the "hidden" case, we have a special case that deletes the actual rendered row. This needs to consider if that row was already mounted or things go wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Already mounted rows that resuspend may be considered as part of a tail if they're at the end. However, for purposes of the tail="..." option they don't get deleted. We deal with that in cutOffTailIfNeeded.
However, if they're also the first to suspend in the "hidden" case, we have a special case that deletes the actual rendered row. This needs to consider if that row was already mounted or things go wrong.